Make npm publish reruns safe#17
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request adds repository metadata to the cli/package.json file. Feedback indicates that the implementation for skipping already published packages, which was mentioned in the PR summary to ensure idempotency, is currently missing from the changes.
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/Conv-AI/convai-analytics.git", | ||
| "directory": "cli" | ||
| }, |
There was a problem hiding this comment.
The pull request summary mentions skipping npm packages that are already published to make reruns safe, but the implementation for this logic (e.g., a check in prepublishOnly or a dedicated script using npm view) is missing from the changes in this file. While the addition of the repository metadata is correct and necessary for provenance validation, the logic to ensure idempotency appears to be missing. If this was intended to be part of this PR, please include the necessary script updates.
Summary
Tests