Conversation
The W3C SSE spec allows \r\n, \r, or \n as line separators. Some upstream providers (notably Azure-hosted OpenAI models) send \r\n\r\n as the frame delimiter instead of \n\n. Without normalization the parser never detects the frame boundary and buffers the entire response until the connection closes, yielding nothing to the protocol adapter. Normalize the buffer to \n after each append so all three line-ending forms are handled correctly. Add regression tests covering CRLF, mixed, and bare-CR frame boundaries.
![orcacode-review[bot]](https://avatars.githubusercontent.com/in/4254738?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 405 calls · 27M tokens · 99% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
The W3C SSE spec allows
\r\n,\r, or\nas line separators. Some upstream providers (Azure-hosted OpenAI models in particular) send\r\n\r\nas the frame delimiter.Without normalization,
OpenAIFrameStream._iter()never finds the\n\nboundary and buffers the entire response in memory until the connection closes — at which point it yields nothing to the protocol adapter. The client sees an empty stream.Fix: normalize
\r\n→\nand\r→\nin the buffer after each append, so all three line-ending forms are handled correctly.Tests added:
test_sse_parses_crlf_frame_boundaries— CRLF-only framestest_sse_parses_mixed_line_endings— mixed CRLF + LFtest_sse_parses_cr_only_line_endings— bare CR (classic Mac-style)