fix(analytics): attribute latency rows with null provider to unknown - #107
Open
mia-lee-hk wants to merge 1 commit into
Open
mia-lee-hk wants to merge 1 commit into
mia-lee-hk wants to merge 1 commit into
Conversation
The latency_by_provider endpoint aggregates request_log rows by provider name. When the LiteLLM adapter fails before routing (e.g. no providers configured, connection refused), the row still gets written with provider=NULL. The aggregation currently creates a null key in the response, which the dashboard frontend renders as "null" in the provider list. Group null-provider rows under "unknown" so the aggregation always produces clean string keys. The p50/p99 calculations are unaffected — only the bucket label changes.
![orcacode-review[bot]](https://avatars.githubusercontent.com/in/4254738?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐳 OrcaCode Review
✅ No findings — nothing to flag in this PR. Great work!
OrcaCode Review — Route Smarter. Ship Safer. Spend Less.
Engine-reported: 473 calls · 30.9M tokens · 99% cached
❤️ Share · Install OrcaCode Review
Free on GitHub — the review runs on your own OrcaRouter key. If it helped, a shout-out goes a long way.
Share: X · Reddit · LinkedIn
Follow: X · Discord · LinkedIn · OrcaRouter
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orca-Code-Review — push 1
✅ no blocking findings
The endpoint aggregates rows by provider name. When the LiteLLM adapter fails before routing (e.g. , DNS failure), the row still gets written with . The aggregation currently creates a key in the response, which the dashboard frontend renders as null in the provider list.
Groups null-provider rows under so the aggregation always produces clean string keys. The p50/p99 calculations are unaffected — only the bucket label changes.
4 tests cover null provider, mixed providers, empty rows, and percentile accuracy for the unknown bucket.