fix(runtime): register SIGTERM before readiness - #123
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
531943e
into
feat/official-threat-feed-refresh
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| #[cfg(all(not(test), not(unix)))] |
There was a problem hiding this comment.
📝 Info: Non-unix path still installs handler lazily
The fix only touches the unix branch. The not(unix) branch remains an async fn, so tokio::signal::ctrl_c() installs only when the future is first polled inside run_from_env, after readiness. The startup race the PR closes on unix still exists on non-unix platforms.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Registers the Unix SIGTERM listener before the gateway publishes readiness, closing the startup race observed by the real binary shutdown contract.\n\nValidation: binary E2E passed 10 consecutive runs; strict workspace Clippy and formatting passed. This is stacked on #115 so the independently observed runtime fix can merge without mixing it into the DNSBL parser commit.