fix(auth): equalize login password-KDF work for unknown users #661
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import assert from 'node:assert'; | ||
| import { spawnSync } from 'node:child_process'; | ||
|
|
||
| const SECRET = '0123456789abcdef0123456789abcdef'; | ||
|
|
||
| const script = ` | ||
| import assert from 'node:assert'; | ||
| import { hashPassword, verifyPassword } from './server/auth.mjs'; | ||
|
|
||
| const DUMMY_HASH = hashPassword(''); | ||
|
|
||
| function simulateLogin(email, password, userFound) { | ||
| const passwordHash = userFound ? hashPassword('correct_password') : null; | ||
| const u = userFound ? { password_hash: passwordHash } : null; | ||
|
|
||
| const isMatch = verifyPassword(typeof password === 'string' ? password : '', u ? u.password_hash : DUMMY_HASH); | ||
|
|
||
| if (!u || typeof password !== 'string' || !isMatch) { | ||
|
Comment on lines
+12
to
+18
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift 실제 인증 엔드포인트를 호출하도록 테스트를 변경하세요.
🤖 Prompt for AI Agents |
||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| try { | ||
| // Test invalid user, returns false but evaluates DUMMY_HASH | ||
| assert.strictEqual(simulateLogin('invalid@test.com', 'pass', false), false); | ||
|
|
||
| // Test valid user, wrong password, returns false | ||
| assert.strictEqual(simulateLogin('valid@test.com', 'wrong', true), false); | ||
|
|
||
| // Test valid user, correct password, returns true | ||
| assert.strictEqual(simulateLogin('valid@test.com', 'correct_password', true), true); | ||
|
|
||
| // Test type mismatch on password, returns false | ||
| assert.strictEqual(simulateLogin('valid@test.com', { invalid: 'type' }, true), false); | ||
|
|
||
| console.log('✓ auth timing integration tests passed'); | ||
| } catch (err) { | ||
| console.error('Test failed:', err); | ||
| process.exit(1); | ||
| } | ||
| `; | ||
|
|
||
| const result = spawnSync(process.execPath, ['--input-type=module', '--eval', script], { | ||
| cwd: process.cwd(), | ||
| env: { ...process.env, SCOPEWEAVE_JWT_SECRET: SECRET }, | ||
| encoding: 'utf8', | ||
| }); | ||
|
|
||
| assert.equal(result.status, 0, result.stderr || result.stdout); | ||
| process.stdout.write(result.stdout); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
보안 학습 문구를 현재 verifier 동작에 맞게 수정하세요.
server/auth.mjs:71-78의verifyPassword는 비문자열 입력에서false를 반환하며TypeError를 발생시키지 않습니다. 또한 현재 변경은 전체 요청의 constant-time 실행을 보장하는 것이 아니라 비밀번호 검증 경로의 비용을 균형화합니다. 두 설명을 실제 동작에 맞게 수정하세요.🤖 Prompt for AI Agents