Repository navigation
π¨ Palette: Replace native disabled with aria-disabled for editor save button #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
1
commit into
develop
from
jules-palette-editor-validation-aria-4426802201096243990
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test.use({ viewport: { width: 375, height: 667 }, isMobile: true, hasTouch: true }); | ||
| test('Clicking disabled save button should show a toast message (Mobile)', async ({ page }) => { | ||
| await page.goto('./'); | ||
|
|
||
| // Click on "μ΅μμ μμ μΆκ°" to open editor | ||
| await page.click('#add-root-task'); | ||
|
|
||
| // Verify the form is present | ||
| const form = page.locator('form[data-editor-form="true"]'); | ||
| await expect(form).toBeVisible(); | ||
|
|
||
| // Find the save button | ||
| const saveButton = form.locator('button[type="submit"]'); | ||
|
|
||
| // Submit the form | ||
| await saveButton.click({ force: true }); | ||
|
|
||
| // Expect toast message to appear | ||
| const toast = page.locator('#toast'); | ||
| await expect(toast).toContainText('μ λ ₯κ°μ μ¬λ°λ₯΄κ² μμ ν΄μΌ μ μ₯ν μ μμ΅λλ€.'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test.use({ viewport: { width: 375, height: 667 }, isMobile: true, hasTouch: true }); | ||
| test('Validation should aria-disable save button instead of native disabled (Mobile)', async ({ page }) => { | ||
| await page.goto('./'); | ||
|
|
||
| // Click on "μ΅μμ μμ μΆκ°" to open editor | ||
| await page.click('#add-root-task'); | ||
|
|
||
| // Verify the form is present | ||
| const form = page.locator('form[data-editor-form="true"]'); | ||
| await expect(form).toBeVisible(); | ||
|
|
||
| // Find the save button | ||
| const saveButton = form.locator('button[type="submit"]'); | ||
|
|
||
| // Since the form is empty, it should be invalid and aria-disabled | ||
| await expect(saveButton).toHaveAttribute('aria-disabled', 'true'); | ||
| await expect(saveButton).not.toHaveAttribute('disabled', ''); | ||
|
|
||
| // Submit the form | ||
| await saveButton.click({ force: true }); | ||
|
|
||
| // Expect form to still be visible (click should be prevented) | ||
| await expect(form).toBeVisible(); | ||
|
|
||
| // Fill in the required field to make it valid | ||
| await page.fill('input[data-editor-field="phase"]', 'Test Phase'); | ||
|
|
||
| // Verify it is no longer aria-disabled | ||
| await expect(saveButton).not.toHaveAttribute('aria-disabled', 'true'); | ||
|
|
||
| // Submit the form | ||
| await saveButton.click(); | ||
|
|
||
| // Verify form is closed | ||
| await expect(form).toBeHidden(); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π‘ Fresh corrections trigger false warning
After the last correction,
submitBtn.getAttribute()can read stale debounced state and block a valid save. Users receive an incorrect validation warning.Prompt for agents
Was this helpful? React with π or π to provide feedback.