fix(a11y): synchronize editor validation before save activation - #594
fix(a11y): synchronize editor validation before save activation#594seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing this draft as superseded by the existing #411 owner lane, PR #468, after a fresh semantic and execution-path comparison. #594 contains only PR #468 now carries the same required behavior in the already-registered The #594 test has no remaining unique product or acceptance behavior that is not represented more realistically and on an executable CI path in #468. Keeping both branches would duplicate issue #411 ownership and preserve a vacuous test lane. No review threads exist here to resolve. |
RED phase
This draft starts from protected
develop@2c328875e00e86537df3e965170be80532571cadand currently contains only the realistic browser regression for #411 at exact contributor head1fb8923b675e05bc9ef123fdea93763141bf41cf.Protected
app.jscurrently drives the editor save state with nativedisabledfrom debounced validation. That removes the invalid save control from keyboard focus and permits the browser's native constraint-validation path to short-circuit the application's live validation before the delegatedsubmithandler. The same debounce can also leave a just-corrected draft looking disabled long enough to reject immediate pointer/Enter activation.The new Playwright acceptance test is intentionally RED until production behavior is repaired. It requires:
aria-disabled="true", and is programmatically described byeditor-errors;The smallest intended production repair is to keep
validateDraft()as the synchronous authority at submit time, prevent native form constraint validation from bypassing that path, and represent the rendered save state witharia-disabledplusaria-describedbyinstead of nativedisabled. A stalearia-disabledpresentation must not itself become the submit decision.Do not merge this test-only head. RED evidence, the minimal production repair, focused/full GREEN evidence, current-head review, and all live governance gates are still required.
Refs #411