-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: computeTaskMetrics 루프 성능 최적화 #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
2
commits into
develop
from
bolt/optimize-compute-metrics-loops-15962930833515522622
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| ## 2026-07-12 - O(N) penalty with Array.shift() in queues | ||
| **Learning:** In Kahn's topological sort and similar algorithms, using `queue.shift()` inside a while loop causes an O(K) penalty per iteration since the entire remaining array needs to be shifted in memory, turning an O(V+E) algorithm effectively into O(V^2+E) worst case. | ||
| **Action:** Always replace `queue.shift()` with a tracking pointer (e.g., `let queueIndex = 0; queue[queueIndex++]`) when using JavaScript arrays as queues in performance-critical graph algorithms. | ||
|
|
||
| ## 2026-07-12 - Optimize renderTaskRow DOM allocations | ||
| **Learning:** Caching unattached template nodes and instantiating them via `.cloneNode(false)` reduces DOM instantiation overhead in O(N) render loops significantly. | ||
| **Action:** Apply this optimization to other hot-path rendering elements such as rows, cells, and stack containers. | ||
|
|
||
| ## 2026-08-23 - Optimize array processing in computeTaskMetrics | ||
| **Learning:** In high-frequency render paths, `Array.prototype.reduce`/`forEach` and `Map` cache structures add noticeable JS engine callback allocation, garbage collection, and hash-lookup overhead. | ||
| **Action:** Replace them with standard `for` loops and typed arrays (e.g., `Int32Array`) to improve O(N) iteration performance when arrays and arrays lengths are known and fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Int32Array cache preserves behavior
Switching from a
task.id-keyedMapto a position-indexedInt32Arraystays correct: both loops iteratestate.tasksin the same order, andcalculateDurationDaysreturns only integers within Int32 range under YYYY-MM-DD validation. As a side effect it avoids the prior collapse of duplicate task ids in the Map.(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.