fix(a11y): expose toast updates as status messages #491
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -741,54 +741,33 @@ function openReportModal() { | |
| export function parseMsProjectXml(xml) { | ||
| // Fully linear extract (indexOf/slice) — no dynamic RegExp and no lazy | ||
| // [\s\S]*? block collectors (those can quadratic-backtrack on truncated input). | ||
| const tag = (block, name) => { | ||
| const openingTag = `<${name}>`; | ||
| const closingTag = `</${name}>`; | ||
| const valueStart = block.indexOf(openingTag); | ||
| if (valueStart === -1) return ''; | ||
| const contentStart = valueStart + openingTag.length; | ||
| const valueEnd = block.indexOf(closingTag, contentStart); | ||
| return valueEnd === -1 ? '' : block.slice(contentStart, valueEnd).trim(); | ||
| }; | ||
| const collectBlocks = (source, openTag, closeTag) => { | ||
| const out = []; | ||
| let from = 0; | ||
| for (;;) { | ||
| const start = source.indexOf(openTag, from); | ||
| if (start === -1) break; | ||
| const contentStart = start + openTag.length; | ||
| const end = source.indexOf(closeTag, contentStart); | ||
| // Incomplete open tag: stop linearly (do not rescan the remainder). | ||
| if (end === -1) break; | ||
| out.push(source.slice(start, end + closeTag.length)); | ||
| from = end + closeTag.length; | ||
| } | ||
| return out; | ||
| }; | ||
| const predecessorIds = (block) => { | ||
| const ids = []; | ||
| for (const link of collectBlocks(block, '<PredecessorLink>', '</PredecessorLink>')) { | ||
| const uid = tag(link, 'PredecessorUID'); | ||
| if (/^\d+$/.test(uid)) ids.push(`msp-${uid}`); | ||
| } | ||
|
|
@@ -800,7 +779,7 @@ export function parseMsProjectXml(xml) { | |
| const day = (s) => (/^\d{4}-\d{2}-\d{2}/.test(s) ? s.slice(0, 10) : ''); | ||
| const tasks = []; | ||
| const parents = {}; // depth -> last task id at that depth | ||
| const blocks = collectBlocks(String(xml || ''), '<Task>', '</Task>'); | ||
|
Contributor
There was a problem hiding this comment. This restores the pre-#467 exact-tag scanner. Restore |
||
| for (const block of blocks) { | ||
| const uid = tag(block, 'UID'); | ||
| const name = unescape(tag(block, 'Name')); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ Every user-controlled CSV cell is neutralized when, after optional leading white | |
|
|
||
| ## XML imports | ||
|
|
||
| Microsoft Project XML extraction uses bounded `indexOf`/`slice` loops. Dynamic regular expressions and lazy whole-document block collectors are prohibited because truncated or adversarial input can cause catastrophic backtracking. | ||
|
Contributor
There was a problem hiding this comment. The whitespace/attribute reject contract from #467 was dropped from this paragraph in the same kick that removed |
||
|
|
||
| ## Release verification | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kick deleted the Unreleased Security line for fail-closed orchestrator briefing and the Changed line for #467 XML whitespace. The toast status line added at
129398cis also gone.Restore those shipped entries. A CI re-kick must not rewrite release truth.