Skip to content

fix: verify production OIDC identities cryptographically - #459

Closed
seonghobae wants to merge 13 commits into
developfrom
fix/oidc-production-verification-20260809
Closed

fix: verify production OIDC identities cryptographically#459
seonghobae wants to merge 13 commits into
developfrom
fix/oidc-production-verification-20260809

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Superseded integration lane

This PR is closed without merge because its historical branch diverged from current protected develop and cannot be safely integrated as-is. The valuable OIDC implementation remains preserved at clean pre-reconciliation commit bfb517cf0ef1ecfab485c4cebc7d2c12c9822fae.

A later attempted ancestry-only reconciliation commit (a5a0f3cc1c7708f57cc7474098121c84c9e7cff8) proved unsafe: although it added current develop as a parent, it retained the historical tree and therefore made the PR diff delete or weaken already-integrated attachment, Clearfolio, session-revocation, coverage, and security behavior. That commit is explicitly rejected as integration evidence and must never be merged.

The next OIDC lane must start from the exact current protected develop tree and reapply only the intended OIDC changes from bfb517c: server/oidc.mjs, OIDC route/unit tests, OIDC documentation/CHANGELOG, package test/coverage registration, and the narrowly scoped OIDC integration in server/app.mjs. It must preserve all current develop security and operability behavior and generate fresh exact-head CI/security/review evidence.

No predecessor-head or historical Security Scan result transfers.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 118 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fd4a5538-61a2-4f32-bcd3-5c7fca2955d7

📥 Commits

Reviewing files that changed from the base of the PR and between b88e66e and a5a0f3c.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (20)
  • CHANGELOG.md
  • docs/deploy.md
  • docs/doctoring/attachment-status-refresh.md
  • docs/doctoring/session-revocation.md
  • docs/oidc-production.md
  • package.json
  • server/app.mjs
  • server/attachment_status.mjs
  • server/auth.mjs
  • server/clearfolio.mjs
  • server/oidc.mjs
  • tests/api/attachment-status.test.mjs
  • tests/api/oidc-route.test.mjs
  • tests/api/session-revocation.test.mjs
  • tests/api/smoke.mjs
  • tests/unit/attachment-status.test.mjs
  • tests/unit/clearfolio-adapter-mock-hmac.test.mjs
  • tests/unit/clearfolio-status-signal.test.mjs
  • tests/unit/coverage-script-contract.test.mjs
  • tests/unit/oidc.test.mjs
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/oidc-production-verification-20260809
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/oidc-production-verification-20260809

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread .github/workflows/one-shot-oidc-production-verification.yml Fixed
@seonghobae
seonghobae changed the base branch from develop to fix/hono-cves-2026-69207-71848-71850 August 11, 2026 21:15
@seonghobae
seonghobae changed the base branch from fix/hono-cves-2026-69207-71848-71850 to develop August 14, 2026 12:48
@seonghobae
seonghobae marked this pull request as ready for review August 14, 2026 13:49
@seonghobae seonghobae closed this Aug 14, 2026
@seonghobae seonghobae reopened this Aug 14, 2026
@seonghobae seonghobae closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants