Skip to content

๐ŸŽจ Palette: ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ์„ ์œ„ํ•œ ํˆดํŒ ํฌ์ปค์Šค ๊ฐœ์„  - #450

Closed
seonghobae wants to merge 4 commits into
developfrom
palette-tooltip-focus-8713624957852357154
Closed

๐ŸŽจ Palette: ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ์„ ์œ„ํ•œ ํˆดํŒ ํฌ์ปค์Šค ๊ฐœ์„ #450
seonghobae wants to merge 4 commits into
developfrom
palette-tooltip-focus-8713624957852357154

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

๐Ÿ’ก ๋ฌด์—‡์„

  • index.html์˜ ํˆดํŒ์ด ์žˆ๋Š” ์š”์•ฝ ์นด๋“œ .meta-value-card 3๊ฐœ์— tabindex="0"๊ณผ role="region" ์†์„ฑ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • app.js์—์„œ ํˆดํŒ์ด ์ถ”๊ฐ€๋˜๋Š” ์ƒํƒœ ๋ฐฐ์ง€ .status-badge์— tabindex="0"๊ณผ role="region" ์†์„ฑ์„ ๋™์ ์œผ๋กœ ๋ถ€์—ฌํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • styles.css์— .meta-value-card:focus-visible ๋ฐ .status-badge:focus-visible ์„ ํƒ์ž๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํ‚ค๋ณด๋“œ ์ดˆ์  ์‹œ ํŒŒ๋ž€์ƒ‰ ๋ง์ด ํ‘œ์‹œ๋˜๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ ์™œ

ํ‚ค๋ณด๋“œ๋กœ ํƒ์ƒ‰ํ•˜๋Š” ์‚ฌ์šฉ์ž๋Š” ๊ธฐ์กด์— div๋‚˜ span ๊ฐ™์€ ๋น„๋Œ€ํ™”ํ˜• ์š”์†Œ์— ํฌ์ปค์Šค๋ฅผ ์ด๋™ํ•  ์ˆ˜ ์—†์—ˆ์Šต๋‹ˆ๋‹ค. ์ด๋กœ ์ธํ•ด ๋งˆ์šฐ์Šค ๋งˆ๋ฒ„(hover) ์‹œ ๋‚˜ํƒ€๋‚˜๋Š” title ํˆดํŒ์„ ํ™•์ธํ•  ๋ฐฉ๋ฒ•์ด ์—†์—ˆ์Šต๋‹ˆ๋‹ค. tabindex="0"์„ ์ถ”๊ฐ€ํ•˜์—ฌ ์ดˆ์ ์„ ๋ฐ›์„ ์ˆ˜ ์žˆ๊ฒŒ ํ•˜๊ณ , ์˜ฌ๋ฐ”๋ฅธ ์‹œ๊ฐ์  ํ”ผ๋“œ๋ฐฑ(:focus-visible)์„ ์ œ๊ณตํ•˜์—ฌ ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž๋„ ํˆดํŒ ์ •๋ณด๋ฅผ ์ฝ์„ ์ˆ˜ ์žˆ๋„๋ก ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค. role="region"์„ ํ†ตํ•ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—๋„ ์˜๋ฏธ ์žˆ๋Š” ์˜์—ญ์ž„์„ ์•Œ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ“ธ ๋ณ€๊ฒฝ ์ „/ํ›„

  • ๋ณ€๊ฒฝ ์ „: ์‚ฌ์šฉ์ž๊ฐ€ Tab ํ‚ค๋ฅผ ๋ˆŒ๋ €์„ ๋•Œ ์š”์•ฝ ์นด๋“œ๋‚˜ ์ƒํƒœ ๋ฐฐ์ง€๋ฅผ ๊ฑด๋„ˆ๋›ฐ์–ด ์‹œ๊ฐ์ /์˜ค๋””์˜ค ํ”ผ๋“œ๋ฐฑ์„ ๋ฐ›์„ ์ˆ˜ ์—†์—ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ณ€๊ฒฝ ํ›„: ์‚ฌ์šฉ์ž๊ฐ€ Tab ํ‚ค๋กœ ์ด๋™ ์‹œ ์š”์•ฝ ์นด๋“œ์™€ ์ƒํƒœ ๋ฐฐ์ง€์— ํŒŒ๋ž€์ƒ‰ ํฌ์ปค์Šค ๋ง์ด ํ‘œ์‹œ๋˜๋ฉฐ ๋ธŒ๋ผ์šฐ์ € ๊ธฐ๋ณธ ํˆดํŒ์ด ํ™œ์„ฑํ™”๋ฉ๋‹ˆ๋‹ค.

โ™ฟ ์ ‘๊ทผ์„ฑ

์ˆœ์ˆ˜ ์‹œ๊ฐ ์žฅ์• ๋ฟ๋งŒ ์•„๋‹ˆ๋ผ, ๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ด ๋ถˆํŽธํ•œ ํ‚ค๋ณด๋“œ ์ „์šฉ ์‚ฌ์šฉ์ž(์šด๋™ ์žฅ์• , ์ผ์‹œ์  ๋ถ€์ƒ ๋“ฑ)๊ฐ€ ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์˜ ํ•ต์‹ฌ ์ •๋ณด(์š”์•ฝ ์ง€ํ‘œ, ์ƒํƒœ ์ƒ์„ธ ์„ค๋ช…)์— ์˜จ์ „ํžˆ ์ ‘๊ทผํ•  ์ˆ˜ ์žˆ๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 8713624957852357154 started by @seonghobae

Summary by CodeRabbit

  • ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 
    • ์ƒํƒœ ๋ฐฐ์ง€์™€ ์š”์•ฝยท์ง„์ฒ™๋ฅ  ์นด๋“œ์— ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค์™€ ์ ์ ˆํ•œ ์˜๋ฏธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ํฌ์ปค์Šค๋œ ์š”์†Œ๊ฐ€ ๋ช…ํ™•ํžˆ ๋ณด์ด๋„๋ก ์‹œ๊ฐ์  ํ‘œ์‹œ๋ฅผ ๊ฐ•ํ™”ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ๋น„์ธํ„ฐ๋ž™ํ‹ฐ๋ธŒ ์š”์†Œ์˜ ํˆดํŒ๊ณผ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ์ง€์นจ์„ ๋ณด์™„ํ–ˆ์Šต๋‹ˆ๋‹ค.

Added `tabindex="0"` and `role="region"` to the summary cards and status badges that have `title` tooltips, and enabled their `:focus-visible` styles in CSS so they can be discovered by keyboard-only users.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

๐Ÿ“ Walkthrough

Walkthrough

์š”์•ฝ ์นด๋“œ์™€ ์ƒํƒœ ๋ฐฐ์ง€๋ฅผ ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค ๋Œ€์ƒ์œผ๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. region ์—ญํ• ๊ณผ title ์„ค๋ช…์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ด€๋ จ ์š”์†Œ์— :focus-visible ์Šคํƒ€์ผ์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. ์ ‘๊ทผ์„ฑ ์ง€์นจ๋„ ๋ฌธ์„œํ™”ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

์ ‘๊ทผ์„ฑ ํฌ์ปค์Šค ์ง€์›

Layer / File(s) Summary
์ ‘๊ทผ์„ฑ ์˜๋ฏธ์™€ ํฌ์ปค์Šค ๋Œ€์ƒ ์ •์˜
\.jules/palette.md, index.html, app.js
๋น„์ธํ„ฐ๋ž™ํ‹ฐ๋ธŒ ์š”์†Œ์˜ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ์ง€์นจ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์š”์•ฝ ์นด๋“œ์™€ ์ƒํƒœ ๋ฐฐ์ง€์— tabindex="0"๊ณผ role="region"์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ์นด๋“œ์—๋Š” ์„ค๋ช…์šฉ title์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
ํฌ์ปค์Šค ํ‘œ์‹œ ์Šคํƒ€์ผ ํ™•์žฅ
styles.css
.meta-value-card์™€ .status-badge์— ๊ธฐ์กด :focus-visible ํฌ์ปค์Šค ํ‘œ์‹œ ๊ทœ์น™์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค. .gantt-bar ๊ทœ์น™์€ ์œ ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Estimated code review effort: 1 (Trivial) | ~5 minutes

๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ ํˆดํŒ ์š”์†Œ์˜ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ๋ช…ํ™•ํ•˜๊ณ  ๊ฐ„๊ฒฐํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches ๐Ÿ’ก 1
๐Ÿ› ๏ธ Fix failing CI checks ๐Ÿ’ก
  • Create stacked PR
  • Commit on current branch
๐Ÿ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-tooltip-focus-8713624957852357154

Comment @coderabbitai help to get the list of available commands.

Added `tabindex="0"` and `role="region"` to the summary cards and status badges that have `title` tooltips, and enabled their `:focus-visible` styles in CSS so they can be discovered by keyboard-only users.
Added `tabindex="0"` and `role="region"` to the summary cards and status badges that have `title` tooltips, and enabled their `:focus-visible` styles in CSS so they can be discovered by keyboard-only users.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

๐Ÿค– Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.jules/palette.md:
- Around line 119-121: Replace the generic role="region" guidance in
.jules/palette.md lines 119-121 with instructions to choose a
context-appropriate non-landmark role or omit the role. In index.html lines
31-42, remove region from summary cards or use an appropriate role such as
group; in app.js lines 1002-1003, stop assigning region to every status badge
and use the role matching each badgeโ€™s meaning.
๐Ÿช„ Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

โ„น๏ธ Review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 431fc7fd-1a74-470c-a320-3f86eb5cc203

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 74a5e99 and 6a20338.

๐Ÿ“’ Files selected for processing (4)
  • .jules/palette.md
  • app.js
  • index.html
  • styles.css

Comment thread .jules/palette.md
Comment on lines +119 to +121
## 2026-08-07 - Non-interactive element tooltips
**Learning:** Adding a `title` to a non-interactive element like a `div` or `span` is not enough for keyboard accessibility.
**Action:** Always add `tabindex="0"` and a valid ARIA role (e.g., `role="region"`) to non-interactive elements with tooltips, and ensure they have a visible `:focus-visible` style.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐ŸŽฏ Functional Correctness | ๐ŸŸก Minor | โšก Quick win

role="region"์„ ํˆดํŒ ์š”์†Œ์˜ ๊ธฐ๋ณธ ์—ญํ• ๋กœ ์‚ฌ์šฉํ•˜์ง€ ๋งˆ์„ธ์š”.

region์€ ๋žœ๋“œ๋งˆํฌ ์—ญํ• ์ž…๋‹ˆ๋‹ค. ์š”์•ฝ ์นด๋“œ์™€ ๊ฐ ์ž‘์—… ํ–‰์˜ ์ƒํƒœ ๋ฐฐ์ง€๋ฅผ ๋ชจ๋‘ region์œผ๋กœ ๋งŒ๋“ค๋ฉด ๋žœ๋“œ๋งˆํฌ ๋ชฉ๋ก์ด ๋ถˆํ•„์š”ํ•˜๊ฒŒ ์ปค์ง‘๋‹ˆ๋‹ค. ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค์—๋Š” role="region"์ด ํ•„์š”ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. ๊ฐ ์š”์†Œ์˜ ์‹ค์ œ ์˜๋ฏธ์— ๋งž๋Š” ๋น„-๋žœ๋“œ๋งˆํฌ ์—ญํ• ์„ ์„ ํƒํ•˜๊ฑฐ๋‚˜ ์—ญํ• ์„ ์ œ๊ฑฐํ•˜์„ธ์š”.

  • .jules/palette.md#L119-L121: role="region"์„ ์ผ๋ฐ˜ ์˜ˆ์‹œ๋กœ ๋ฌธ์„œํ™”ํ•˜์ง€ ๋ง๊ณ , ์˜๋ฏธ์— ๋งž๋Š” ์—ญํ•  ์„ ํƒ์„ ์š”๊ตฌํ•˜์„ธ์š”.
  • index.html#L31-L42: ์š”์•ฝ ์นด๋“œ์—์„œ region์„ ์ œ๊ฑฐํ•˜๊ฑฐ๋‚˜ group ๋“ฑ ์ ์ ˆํ•œ ๋น„-๋žœ๋“œ๋งˆํฌ ์˜๋ฏธ๋ฅผ ์‚ฌ์šฉํ•˜์„ธ์š”.
  • app.js#L1002-L1003: ์ƒํƒœ ๋ฐฐ์ง€๋งˆ๋‹ค region์„ ์ƒ์„ฑํ•˜์ง€ ๋ง๊ณ , ์ƒํƒœ ๋ฐฐ์ง€์˜ ์˜๋ฏธ์— ๋งž๋Š” ์—ญํ• ์„ ์‚ฌ์šฉํ•˜์„ธ์š”.
๐Ÿ“ Affects 3 files
  • .jules/palette.md#L119-L121 (this comment)
  • index.html#L31-L42
  • app.js#L1002-L1003
๐Ÿค– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.jules/palette.md around lines 119 - 121, Replace the generic role="region"
guidance in .jules/palette.md lines 119-121 with instructions to choose a
context-appropriate non-landmark role or omit the role. In index.html lines
31-42, remove region from summary cards or use an appropriate role such as
group; in app.js lines 1002-1003, stop assigning region to every status badge
and use the role matching each badgeโ€™s meaning.

Added `tabindex="0"` and `role="region"` to the summary cards and status badges that have `title` tooltips, and enabled their `:focus-visible` styles in CSS so they can be discovered by keyboard-only users.

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #445 and to avoid incorrect landmark semantics. The live diff is the same focusability/focus-ring change, but adds role="region" to every summary card and described status badge. WAI-ARIA regions are structural landmarks that need meaningful naming; using them as generic tooltip semantics can create landmark noise. Keep the narrower #445 branch for any follow-up, and if a real custom tooltip is needed use a described tooltip relationship rather than manufacturing regions.

@seonghobae seonghobae closed this Aug 9, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as a duplicate of #445 and to avoid incorrect landmark semantics. The live diff is the same focusability/focus-ring change, but adds role="region" to every summary card and described status badge. WAI-ARIA regions are structural landmarks that need meaningful naming; using them as generic tooltip semantics can create landmark noise. Keep the narrower #445 branch for any follow-up, and if a real custom tooltip is needed use a described tooltip relationship rather than manufacturing regions.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant