fix(security): enforce strict revocable sessions on every JWT transport - #436
Closed
seonghobae wants to merge 5 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Aug 4, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restack the session-revocation security boundary directly on the exact attachment-security head from #432. This clean five-file change replaces the diverged #414 branch without reintroducing historical attachment code.
HS256/JWTheader, object claims, positive safe-integer subject, future safe-integer expiry, and non-negative safe-integertoken_version.logout-allrevocation applies uniformly to every transport.docs/doctoring/session-revocation.mdand record the security change inCHANGELOG.md.Exact scope
Relative to #432's exact head, only five files change:
CHANGELOG.mddocs/doctoring/session-revocation.mdpackage.jsonserver/auth.mjstests/api/session-revocation.test.mjsNo attachment-list, Clearfolio, database-schema, UI, deployment, workflow, or dependency code is changed by this pull request.
Security and standards contract
The doctoring record maps the implementation to RFC 7519, RFC 8725, RFC 6750, and RFC 9700. This pull request does not claim to remove the existing query-token transport. It provides one strict revocation boundary until #413 replaces general session JWTs in URLs with narrowly scoped opaque grants and separately revocable calendar subscription secrets.
Verification contract
The exact current head must prove:
logout-allrejects both stale sessions on bearer, calendar, SSE, and attachment-view paths;Sequencing
This pull request intentionally targets
fix/security-hono-attachment-refresh-finaland remains Draft while #432 is under protected-branch review. After #432 merges, retarget or restack this exact five-file change ontodevelop, rerun every exact-head check, obtain an independent approval, and only then enable auto-merge.Supersedes #414.