fix(health): project CLI readiness output - #356
Draft
seonghobae wants to merge 3 commits into
Draft
seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #203, #316, #323.
Serialized canonical child
This Draft remains serialized directly behind the current PostgreSQL-driver owner instead of racing a sibling writer.
main@5913c4bad79d6bc29d7cc1c624abb7db2ea6a77c;feat/commercial-postgres-driver-port-b84f0c9@797b929b1e2cbc0f8a5568bea89841d0f8c193ad;766b380c1fc04252c7d044fbbbbf9b8067bbc118;b12d7c06a505241e09192275ba93a3c275ad1ca3;1bec226b1e8f8966f309f7513a5d61022483183c;pg_llm_batch/cli.py,tests/test_health_public_boundary_current.py, andtests/test_bootstrap_cli.py;pg_llm_batch/health.pyremains unchanged in this child.#323 remains the active parent owner for
cli.py,health.py, and the focused public-health boundary. This child preserves that stack relationship.Executed disclosure RED
The test-only predecessor
766b380c...executed on GitHub-hosted runners. CI35507238842completed FAILURE while Release Acceptance35507238854completed SUCCESS.The focused regression drives the real CLI parser/dispatch path, injects an internal health report containing credential-shaped
detaildata and an unknown component, preserves not-ready exit code1, and requires stdout to equal the existingpublic_health_report()projection. The inherited production path printed the rawcheck_health()report, so this was genuine source-level disclosure RED rather than queue or runner failure.Minimum production repair
Ordinary-forward
b12d7c06a505241e09192275ba93a3c275ad1ca3changes only the default CLI serialization boundary:public_health_report()projection fromhealth.py;public_health_report(report)for the defaulthealthcommand instead of the raw internal report.The exit decision still uses the internal report's
readyvalue.check_health()remains the operator-internal diagnostic source,/healthzretains its existing projection and 200/503 behavior, and no privileged diagnostic mode was introduced.Induced stale-test RED and repair
The repaired production head
b12d7c06...then executed. Release Acceptance35537437760completed SUCCESS while CI35537437783completed FAILURE. The real container/PostgreSQL candidate job succeeded end-to-end. The sole unit failure wastests/test_bootstrap_cli.py::test_count_health_and_server_commands, which still asserted the old raw{"ready": false}shape while the repaired CLI correctly returned{"ready": false, "components": []}.Ordinary-forward current commit
1bec226b1e8f8966f309f7513a5d61022483183cchanges only that stale assertion to the explicit public shape. It does not alter production code,public_health_report(), readiness semantics, or the focused credential/detail redaction regression.Exact-current repository evidence
Exact
1bec226b1e8f8966f309f7513a5d61022483183cis now repository-local GREEN:35559622692: completed / success. The exact-head workflow passed the supported Python unit lanes, compile/lint/docstring/coverage/package checks, component/PostgreSQL builds and runtime smokes, exact pg8000 candidate checks, SBOM generation/policy, and real PostgreSQL smokes on Python 3.10/3.12/3.14.35559622691: completed / success. It checked out the exact PR head, materialized two clean exact-head source trees, built wheel/sdist twice, and verified artifact identity before preserving bounded release evidence.This establishes exact-current repository acceptance for the disclosure repair and its induced test repair. It does not establish independent approval, protected ancestry, central-governance satisfaction, protected-main behavior, or immutable release authority. Keep Draft. If #323 or another parent prerequisite moves, reconcile ordinary/non-force and reacquire all exact-final-head/current-base evidence.
No force update, destructive rebase, self-approval, gate weakening, routine administrator bypass, blind rerun, source-neutral wake commit, merge, release claim, predecessor-evidence transfer, or issue closure is authorized.