Skip to content

fix(health): project CLI readiness output - #356

Draft
seonghobae wants to merge 3 commits into
feat/commercial-postgres-driver-port-b84f0c9from
fix/cli-health-diagnostic-boundary-203
Draft

seonghobae wants to merge 3 commits into
feat/commercial-postgres-driver-port-b84f0c9from
fix/cli-health-diagnostic-boundary-203

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Refs #203, #316, #323.

Serialized canonical child

This Draft remains serialized directly behind the current PostgreSQL-driver owner instead of racing a sibling writer.

#323 remains the active parent owner for cli.py, health.py, and the focused public-health boundary. This child preserves that stack relationship.

Executed disclosure RED

The test-only predecessor 766b380c... executed on GitHub-hosted runners. CI 35507238842 completed FAILURE while Release Acceptance 35507238854 completed SUCCESS.

The focused regression drives the real CLI parser/dispatch path, injects an internal health report containing credential-shaped detail data and an unknown component, preserves not-ready exit code 1, and requires stdout to equal the existing public_health_report() projection. The inherited production path printed the raw check_health() report, so this was genuine source-level disclosure RED rather than queue or runner failure.

Minimum production repair

Ordinary-forward b12d7c06a505241e09192275ba93a3c275ad1ca3 changes only the default CLI serialization boundary:

  1. import the existing public_health_report() projection from health.py;
  2. serialize public_health_report(report) for the default health command instead of the raw internal report.

The exit decision still uses the internal report's ready value. check_health() remains the operator-internal diagnostic source, /healthz retains its existing projection and 200/503 behavior, and no privileged diagnostic mode was introduced.

Induced stale-test RED and repair

The repaired production head b12d7c06... then executed. Release Acceptance 35537437760 completed SUCCESS while CI 35537437783 completed FAILURE. The real container/PostgreSQL candidate job succeeded end-to-end. The sole unit failure was tests/test_bootstrap_cli.py::test_count_health_and_server_commands, which still asserted the old raw {"ready": false} shape while the repaired CLI correctly returned {"ready": false, "components": []}.

Ordinary-forward current commit 1bec226b1e8f8966f309f7513a5d61022483183c changes only that stale assertion to the explicit public shape. It does not alter production code, public_health_report(), readiness semantics, or the focused credential/detail redaction regression.

Exact-current repository evidence

Exact 1bec226b1e8f8966f309f7513a5d61022483183c is now repository-local GREEN:

  • CI 35559622692: completed / success. The exact-head workflow passed the supported Python unit lanes, compile/lint/docstring/coverage/package checks, component/PostgreSQL builds and runtime smokes, exact pg8000 candidate checks, SBOM generation/policy, and real PostgreSQL smokes on Python 3.10/3.12/3.14.
  • Release Acceptance 35559622691: completed / success. It checked out the exact PR head, materialized two clean exact-head source trees, built wheel/sdist twice, and verified artifact identity before preserving bounded release evidence.
  • exact comparison remains 3 ahead / 0 behind feat(postgres): define driver-neutral migration port #323 with merge base exactly feat(postgres): define driver-neutral migration port #323 and only the three files listed above;
  • fresh formal review inventory: empty;
  • fresh inline review-thread inventory: empty.

This establishes exact-current repository acceptance for the disclosure repair and its induced test repair. It does not establish independent approval, protected ancestry, central-governance satisfaction, protected-main behavior, or immutable release authority. Keep Draft. If #323 or another parent prerequisite moves, reconcile ordinary/non-force and reacquire all exact-final-head/current-base evidence.

No force update, destructive rebase, self-approval, gate weakening, routine administrator bypass, blind rerun, source-neutral wake commit, merge, release claim, predecessor-evidence transfer, or issue closure is authorized.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title test(health): prove CLI diagnostic disclosure fix(health): project CLI readiness output Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant