docs: make README links registry-safe - #352
seonghobae wants to merge 15 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughREADME의 저장소 문서 링크를 GitHub 절대 URL로 변경했습니다. 일부 운영·보안·관측성 문서 링크와 설명을 제거했습니다. 원격 배치 수명주기, 논문, 라이선스 링크를 갱신했습니다. ChangesREADME 문서 링크 정리
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The PR only updates documentation links and descriptions, with no demonstrated impact on runtime behavior or packaging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Descendant topology repair: Draft #353 has now been serialized directly behind this exact head instead of competing from protected |
Canonical public-surface successor
This Draft preserves registry-safe package README links and owns the README-side public wording inherited from #321 without competing with #321's
docs/index.mdauthority.Exact current topology — 2026-09-20
d5057439ecf41e237958905c001894b045383d10;797b929b1e2cbc0f8a5568bea89841d0f8c193adand is repository-local GREEN: CI35447536510SUCCESS, Release Acceptance35447536575SUCCESS;b08218d2de8bf1c9c65a5f928f29c31ceb02b890;5cdbd57ab66c39c92c921cf3c88897938a6c61cb;README.md,tests/test_readme_registry_links.py, andtests/test_count_tokens_stdin_documentation.py;35477695148: SUCCESS;35477695138: SUCCESS;Predecessor and parent evidence did not transfer; the current exact head has now independently reacquired repository-local CI and Release Acceptance. Absence of review is not approval, and this Draft remains unintegrated branch authority only.
Reality RED → minimum causal repair
Predecessor exact
b08218d2...reached a genuine repository-owned RED: CI35456862486FAILED while Release Acceptance35456862455succeeded. Python 3.12 job105933589083reported1 failed, 1689 passed, 5 deselected, 1 warning. The deterministic failure wastests/test_count_tokens_stdin_documentation.py::test_readme_does_not_claim_retired_sql_provider_authority.The stale test still required the old literal two-line claim
former bundledpg_cron+pgsql-httpprovider retriever is\nretired. That no longer matched the stronger buyer contract already guarded bytests/test_readme_registry_links.py: fresh initialization no longer creates the retriever, but upgraded volumes can still retain legacy extension/schedule/object state until the preservation-first retirement migration reaches protectedmain.Current commit
5cdbd57ab66c39c92c921cf3c88897938a6c61cbis the minimum causal repair. It changes only the stale executable documentation assertion so it now requires the same two-stage truth already expressed by the README and the newer registry-link regression:(or) pg_cron jobarchitecture path;pg_cron+httpprovider retriever;The README was not weakened or rewritten to satisfy the stale assertion, and
tests/test_readme_registry_links.pywas not relaxed.Writer-census boundary for the repair
The invocation-scoped branch collection was freshly paginated to exhaustion (
per_page=100: pages 1 and 2 non-empty, page 3 empty). The historical owner that introducedtests/test_count_tokens_stdin_documentation.py, merged PR #173, is already integrated into protected ancestry and its oldfix/count-tokens-stdin-privacyhead ref is no longer present. Current documentation owners #321, #353, #229 and #324 do not change this test path; #353 remains an active overlapping writer only forREADME.md/docs/index.mdand is serialized behind #321→#352. Current token-counter/diagnostic PRs #343/#344 also own disjoint files.This repair therefore avoids the actively contested README path and extends the existing canonical #352 lane only with the stale test that directly caused its exact-head RED. No competing source branch was created.
Independent warning owner correction
The predecessor CI's
compose_bootstrap/runpyRuntimeWarning is not owned here. Fresh discovery found the existing canonical repair at Draft #252, exacte3668344af050672387ca58e59ea24d23d98e51b, with an effective one-filetests/test_compose_bootstrap.pydelta and exact CI34394437612/ Release Acceptance34394437587SUCCESS. Issue #354 now points to #252 and remains open until that stack reaches protectedmain; this PR does not copy or suppress the warning repair.Causal public-contract repairs retained
Legacy SQL provider-network retirement
Fresh initialization and upgraded-volume truth are different authorities. This Draft states that fresh initialization no longer creates the former provider-retrieval path; existing volumes can still contain legacy extension/schedule/object state; compatibility image package/preload retention remains transitional; and #103/#184 own preservation-first retirement plus the later image/package/preload removal stage. This does not modify migration, Docker image, preload configuration, schema, or runtime authority.
Secret storage and health diagnostics
SecretStoreencryption is conditional on a Fernet key unlessrequire_encryption=True; mandatory migration/key lifecycle remains #121./healthzis the fixed-name/boolean content-minimal public projection while the current standalone CLI health report remains operator-facing and unprojected; runtime disclosure hardening remains #203.Registry-safe public links retained
tests/test_readme_registry_links.pyrequires absolute package-registry-safe links for lifecycle, tenant/RLS, bootstrap/secret/input, legacy-network-retirement, observability, papers, license, and notice destinations. It also protects the secret-storage, health-disclosure, and fresh-init-versus-existing-volume retirement boundaries.Integration boundary
#321 and #323 remain unintegrated Draft parents despite exact-head repository-local GREEN. #184's repository-local GREEN retirement migration is not protected-main authority and does not authorize removing compatibility image packages/preload. Normal order remains central prerequisite convergence → #233 protected integration → #323 → #321 → this child normal integration after live governance/review requirements are satisfied → existing-volume retirement integration → later image/package/preload removal with rollback evidence → canonical documentation/release convergence.
Keep Draft while upstream governance/integration prerequisites remain unresolved. No self-approval, source-neutral wake commit, synthetic status, protection weakening, routine administrator bypass, destructive rebase, force update, predecessor/parent evidence transfer, blind rerun, or PR close is authorized.