docs(recovery): bind target observer operator handoff - #348
Draft
seonghobae wants to merge 25 commits into
Draft
seonghobae wants to merge 25 commits into
seonghobae wants to merge 25 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 16, 2026
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
PR #299's bounded recovery-target configuration observer has a cross-owner public/operator documentation contract. This PR owns only ADR 0019, physical/PITR doctoring and their focused documentation test; it does not own runtime/schema/provider authority.
Parent #324 is the canonical root architecture/product-gap documentation owner. Its latest change repairs a durable/mutable authority defect in
docs/product-technical-gap-baseline.md; this descendant inherits that parent documentation through ordinary ancestry and does not duplicate it into recovery-owned files.Exact topology
fix/result-application-semantic-identifiers@782620982520fed46f6b6ef68c7320a61dbb311f;0d8cca0ec9e2ff2dca366eac198017c6e3e1fede;docs/postgres-recovery-target-observer-handoff@143cbca70a46923b2a56bd419058c419f933dda0;force=false;docs/adr/0019-postgres-physical-pitr-profile.md,docs/doctoring/postgres-physical-pitr-profile.md, andtests/test_postgres_physical_recovery_documentation.py.The parent change touches only the product-gap baseline, so the recovery-owned three-file slice remains lossless and non-overlapping.
Retained recovery contract
The handoff preserves exactly eight recovery-target settings plus
pg_is_in_recovery(), bounded result materialization, fail-closed malformed/duplicate/unknown/oversized/pending-restart/inactive/mismatch handling, caller-owned connection/timeout policy and content-free provenance. Wrong-type or mutatedPostgresPitrRecoveryTargetauthority that no longer satisfies the reviewed contract is rejected before cursor acquisition/database I/O. PostgreSQL 18's effectiverecovery_target_inclusive=ondefault remains explicit when a reviewednameorimmediatetarget has no inclusion edge; time/XID/LSN retain their explicit reviewed inclusion edge.The seam does not create
recovery.signal, providerestore_command, replay/validate WAL, prove archive completeness/timeline ancestry/target attainment, promote recovery, prove application readiness, or establish achieved RPO/RTO, HA/DR or certification.Exact-current acceptance
The previous repository-local GREEN receipts on #348
0d8cca0e...and parent #324056025a8...are predecessor evidence only after the parent and descendant moved. They do not transfer.Fresh exact-current runs are nonterminal:
143cbca70a46923b2a56bd419058c419f933dda0: CI35603177444queued; Release Acceptance35603177440queued.782620982520fed46f6b6ef68c7320a61dbb311f: CI35603122673queued; Release Acceptance35603122824queued.Keep Draft until this exact source generation obtains fresh terminal evidence and then-live review/governance requirements are satisfied.
Authority boundary
ADR 0019 remains Accepted only for the already-integrated bounded physical/PITR profile seam; the #299 observation handoff remains proposed until normally integrated. Moving central owner identities, workflow runs, queue state and review/governance topology are resolved from #244 and live central owners immediately before any integration decision rather than frozen into this durable recovery PR.
No wake/no-op commit, blind rerun, gate weakening, self-approval, administrator bypass, predecessor-evidence transfer, force update or destructive rebase is authorized. Refs #102, #109, #111, #121, #122, #184, #198, #200, #203, #204, #229, #233, #244, #278, #299, #306, #308, #309, #312, #316, #321, #324, #340, #341 and #345.