feat(recovery): assess PostgreSQL timeline history - #241
Draft
seonghobae wants to merge 5 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 17, 2026
seonghobae
changed the base branch from
main
to
fix/recovery-evidence-weakref-coverage-b84f0c9
August 19, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assess bounded PostgreSQL timeline-history bytes into content-free structural ancestry evidence without claiming archive provenance, WAL-byte authority, replay, promotion, PITR, RPO, or RTO.
Exact stack boundary
main:b84f0c94154043a3473939c01bb6471de5a129aefix/recovery-evidence-weakref-coverage-b84f0c95951b7a4d779903b8924abaef2a387cae50b7f54feat/postgres-timeline-history-b84f0c95f804f040e5611964219b455dd60d5faf8f6b995pg_llm_batch/postgres_timeline_history.pytests/test_postgres_timeline_history.py5f804f0...is a non-destructive merge commit retaining the original timeline-history lineage and exact #233 head5951b7a...as parents. It includes #233's focused weak-reference coverage regression only as predecessor history; that test is not part of this PR's relative diff. No source or documentation was written directly to protected main.Fresh targeted writer inventory finds only
feat/postgres-timeline-history-b84f0c9on this exact source surface. Fresh formal-review inventory remains empty; absence of review is not approval.RED → GREEN lineage
5a3fdde690343d2182eac56a46d57df35bda83a6— tests-first contract; the production import intentionally failed.5f91e11e2e56b7cd7865a4ad7eba4945bbe200e4— product-lineage tip before stacking, including focused syntax/empty-history coverage.Contract boundary
assess_postgres_timeline_history(...)accepts an explicit target timeline ID plus at most 64 KiB of raw history bytes. It parses only authority-bearing parent timeline IDs and switchpoint LSNs, ignores comments/blank lines and untrusted reason text, requires increasing parent timelines below the child and nondecreasing switchpoints, canonicalizes LSNs, and binds the assessment to the exact input bytes with SHA-256.Timeline 1 may contain only comments/blank content; later timelines require at least one parent entry. The result does not prove source provenance, archive completeness, cluster identity, WAL continuity, replay, target promotion, or deployment recovery objectives.
Exact validation state
Pre-stack exact head
5f91e11e2e56b7cd7865a4ad7eba4945bbe200e4produced terminal-success Security Scan32053574925, SAST Semgrep32053574998, Release Acceptance32053574879, Python 3.10/3.12/3.14 unit lanes, PostgreSQL/container smokes, compile, Ruff, and 100% public-docstring coverage. CI32053574902failed only at repository aggregate coverage: the timeline-history module was exact 100%, 1352 tests passed, and the only uncovered branches were protected-mainpostgres_backup_evidence.py:65->exitandpostgres_schema_evidence.py:49->exit, owned by dependency-root #233. That predecessor evidence is RCA context only and does not transfer.For unchanged exact stacked head
5f804f040e5611964219b455dd60d5faf8f6b995, repository-local workflows concluded terminal-success:32209482371: success;32209482337: success;32209482351: success; and32209482409: success.Those historical conclusions remain branch evidence only. Final integration still requires fresh proof that every then-required scanner actually analyzed the final contributor head under then-protected central semantics. No predecessor, synthetic, or stale evidence transfers.
Dependency and governance boundary — refreshed 2026-08-30
#233 is the exact predecessor and must integrate first. The former read-only central coverage/review failure is historical RCA rather than the current capability boundary. Unchanged #233 now has fresh exact-contributor-head CI, Release Acceptance, Trivy Security Scan, Semgrep SAST and bounded Strix evidence under protected central semantics. None of that evidence transfers to this child.
#233 remains non-passing because its active same-head OpenCode formal state is still
CHANGES_REQUESTED, that disposition has not been superseded by a fresh qualifying semantic review, and no qualifying approval exists under live governance. Central.githubremains read-only; mutable control-plane/reviewer/provider truth is centralized in #244. Do not mutate central, copy its workaround, churn pg heads merely to manufacture events, or transfer predecessor evidence.This branch owns only the two timeline-history files above and does not mutate WAL receive, PITR target binding, WAL filename continuity, WAL-byte binding, canonical-documentation writer #229, or read-only central dependencies.
After #233 integrates, retarget/reconcile this PR non-destructively to then-current protected main, prove the relative diff remains exactly the two timeline-history files, and reacquire every exact-final-head/current-base CI, security, coverage, package, SBOM, provenance, release, review, and thread-resolution gate. Merge only with the qualifying independent non-author approval required by then-live policy.
Queued, pending, cancelled, skipped-required, absent, neutral, stale, predecessor, status-only, synthetic, author-only, rate-limited, infrastructure-failed, dismissed, or conclusion-null evidence is non-passing.
Refs #204, #233, #244.