Skip to content

feat(reconcile): integrate bounded reconciliation on protected main - #189

Merged
seonghobae merged 2 commits into
mainfrom
feat/provider-reconciliation-worker-main-291a34a
Aug 14, 2026
Merged

seonghobae merged 2 commits into
mainfrom
feat/provider-reconciliation-worker-main-291a34a

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Bounded provider reconciliation — integrated-main reconstruction

This PR non-destructively reconstructs the reviewed reconciliation slice from superseded #188 onto the exact protected main produced by merged checkpoint-store PR #181. No predecessor checks, reviews, approvals, mergeability result, or synthetic merge evidence transfer.

Exact topology at creation

  • protected main: 291a34a8d3130b2f93d7003c534bd3ea76ecf1e1;
  • exact contributor head: 3fb7e283f64686fb33c178fa3166ead7ea7b698a;
  • merge base: exact protected main;
  • comparison: 2 commits ahead / 0 behind;
  • delta: exactly pg_llm_batch/reconciliation.py and tests/test_provider_reconciliation_worker.py;
  • both paths were absent on protected main before reconstruction;
  • the source/test contents preserve the hardened final feat(reconcile): rebuild bounded reconciliation on current main #188 content, including the current CodeRabbit findings already addressed there.

Test-first / review lineage

Predecessor development established observable RED evidence for the absent reconciliation module, later found and fixed silent candidate-scan truncation, then addressed CodeRabbit findings for finite domain error categories, deferred downloads, unknown status bounding, limit-derived saturation fixtures, and the conditional retrieval outcome expression.

Those historical results explain the implementation but are not validation for this head. This exact reconstructed head must independently reacquire current-live-base CI, coverage/docstrings, security, package/container/provenance/release, and every live required organization workflow.

Implemented contract

The primitive:

  • validates host-selected endpoint/batch identities before provider I/O;
  • deduplicates candidates and enforces finite unique-work and candidate-scan budgets;
  • fails closed when bounded scanning would hide later unique work;
  • polls/retrieves only through the supplied validated Batch API client seam;
  • returns only bounded status/error categories and never provider payloads/dynamic exception diagnostics; and
  • isolates one ordinary provider failure without preventing later candidate work.

Scope boundary

This remains only the scheduler-independent primitive. It does not yet provide durable discovery from llm_remote_batch_jobs, tenant-qualified cross-process lease/single-flight semantics, CLI/service scheduling, durable result application/checkpoint coupling, or distributed exactly-once delivery. Issue #102 remains the residual product lane.

Promotion boundary

Merge only if this unchanged exact head stays based on the exact live protected tip, is mergeable, independently passes repository CI plus exact 100% owned statement/branch coverage and public-docstring enforcement, Python 3.10/3.12/3.14, Security Scan, SAST, CodeQL/OSV/Trivy, Release Acceptance, package/container/provenance evidence and every ruleset-required central workflow, with zero valid unresolved findings. Broad canonical documentation remains owned by #93 and must not be raced.

Supersedes #188 source topology. Refs #102.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 78 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 096da282-26f6-4e3d-9c8a-aed4013db6bb

📥 Commits

Reviewing files that changed from the base of the PR and between 291a34a and 3fb7e28.

📒 Files selected for processing (2)
  • pg_llm_batch/reconciliation.py
  • tests/test_provider_reconciliation_worker.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant