fix(durable): bound provider lifecycle fields - #170
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough원격 provider lifecycle의 ChangesProvider lifecycle contract
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RED phase for #127
Protected main
cd873be84361cceca81e961d757b373a7c4ea95bnow enforces durable progress invariants, but durable lifecycle normalization still accepts arbitrary nonempty providerstatusandendpointtext. That allows unsupported/high-cardinality lifecycle state to become persistence input and leaves terminal semantics dependent on an unvalidated string.This Draft starts from that exact protected head and is intentionally test-only RED. The regression requires unsupported/missing/control-bearing status or endpoint evidence to fail before PostgreSQL acquisition, without copying the rejected provider value into the package-owned error, while preserving the currently documented OpenAI Batch status set and endpoint set.
Current OpenAI Batch API reference evidence (checked 2026-08-13) documents the supported batch endpoints
/v1/responses,/v1/chat/completions,/v1/embeddings,/v1/completions, and/v1/moderations, and lifecycle examples/fields covervalidating,failed,in_progress,finalizing,completed,expired,cancelling, andcancelled. Provider-specific extensions remain outside first-party verified compatibility unless independently reviewed.After the expected RED is observed, the narrow GREEN will change only the durable normalization boundary and focused assurance/doctoring needed for that contract. No schema migration, credential authority, provider transport, scheduler, model, or release authority is intended.
Refs #127.
Summary by CodeRabbit
개선 사항
문서
테스트