fix(bootstrap): rebuild explicit source precedence on current main - #139
Conversation
|
Warning Review limit reached
Next review available in: 20 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Rebuild the explicit bootstrap source/type authority repair directly on the current protected-main line instead of carrying stale #89 ancestry.
RCA and TDD boundary
Protected main still uses truthiness (
explicit or environment) inresolve_dsn()andresolve_secret_key(). That conflates omission with explicitly supplied false/blank values and can silently select ambient database or decryption authority. It also lets non-string explicit inputs reach unrelated behavior instead of one bounded package-domain failure.This replacement starts from protected
mainat20283526e3b23f9ceb144a90467763e1f4910321. Current RED headffebb943adadc5bd44d75e1b47a31a5e5151eca0adds only focused source-precedence/type tests. The tests require explicit invalid DSNs/keys never to inherit environment authority, omitted blank DSNs to fail, valid explicit DSNs to retain exact text, and an explicit empty secret key to remain explicit rather than falling back.No #89 checks/reviews transfer. Production and documentation changes follow only after the RED is observed on this exact replacement relation.
Intended bounded behavior
None);str;strwhen supplied;Keep Draft until RED -> GREEN, documentation reconciliation, full exact-head validation, and live review/thread/ruleset gates are satisfied.