Skip to content

fix(bootstrap): rebuild explicit source precedence on current main - #139

Merged
seonghobae merged 6 commits into
mainfrom
fix/bootstrap-source-precedence-v2
Aug 12, 2026
Merged

seonghobae merged 6 commits into
mainfrom
fix/bootstrap-source-precedence-v2

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Rebuild the explicit bootstrap source/type authority repair directly on the current protected-main line instead of carrying stale #89 ancestry.

RCA and TDD boundary

Protected main still uses truthiness (explicit or environment) in resolve_dsn() and resolve_secret_key(). That conflates omission with explicitly supplied false/blank values and can silently select ambient database or decryption authority. It also lets non-string explicit inputs reach unrelated behavior instead of one bounded package-domain failure.

This replacement starts from protected main at 20283526e3b23f9ceb144a90467763e1f4910321. Current RED head ffebb943adadc5bd44d75e1b47a31a5e5151eca0 adds only focused source-precedence/type tests. The tests require explicit invalid DSNs/keys never to inherit environment authority, omitted blank DSNs to fail, valid explicit DSNs to retain exact text, and an explicit empty secret key to remain explicit rather than falling back.

No #89 checks/reviews transfer. Production and documentation changes follow only after the RED is observed on this exact replacement relation.

Intended bounded behavior

  • environment fallback occurs only when the explicit argument is omitted (None);
  • explicit Postgres DSN must be an exact nonblank str;
  • omitted environment DSN must be a nonblank string;
  • explicit Fernet bootstrap key must be an exact str when supplied;
  • explicit empty secret key remains empty and does not inherit ambient decryption authority;
  • valid explicit values remain unchanged;
  • no provider, schema, persistence, HTTP, release, or model contract change.

Keep Draft until RED -> GREEN, documentation reconciliation, full exact-head validation, and live review/thread/ruleset gates are satisfied.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 76df1840-441e-4c6f-8ec7-76fc1e2df1ef

📥 Commits

Reviewing files that changed from the base of the PR and between 2833e5f and 391f236.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/doctoring/bootstrap-dsn-precedence.md
  • pg_llm_batch/bootstrap.py
  • tests/test_bootstrap_source_precedence.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 12, 2026 01:05
@seonghobae
seonghobae merged commit cd7f724 into main Aug 12, 2026
34 checks passed
@seonghobae
seonghobae deleted the fix/bootstrap-source-precedence-v2 branch August 12, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant