Skip to content

fix(security): redact GatewayCredentials representations - #137

Merged
seonghobae merged 6 commits into
mainfrom
fix/gateway-credentials-repr
Aug 11, 2026
Merged

seonghobae merged 6 commits into
mainfrom
fix/gateway-credentials-repr

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Test-first security repair for #128

Protected main now includes #71, so the former provider-client writer dependency is satisfied. This bounded branch hardens only GatewayCredentials representation confidentiality without changing credential resolution or transport semantics.

Current RED head c29cdc40139cea6d9c43a9e69bfb75e528e270b6 adds a focused regression proving provider API-key sentinel material must not appear in repr() or str(), while preserving constructor access, equality behavior, class identity, and visible non-secret gateway URL. The production fix will follow on this same branch after the intended RED is observed.

No serialization, encryption, persistence, provider protocol, workflow, schema, or release authority claim is made. Direct attribute access and caller-controlled serialization remain separate authority surfaces.

Refs #128.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bdd12a75-6ade-4e7a-8ecb-7c10402a2be0

📥 Commits

Reviewing files that changed from the base of the PR and between bf0f5c0 and e54631f.

📒 Files selected for processing (2)
  • pg_llm_batch/batch_api_client.py
  • tests/test_gateway_credentials_representation.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread tests/test_gateway_credentials_representation.py Fixed
@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 22:58
@seonghobae
seonghobae merged commit a38ce8e into main Aug 11, 2026
33 checks passed
@seonghobae
seonghobae deleted the fix/gateway-credentials-repr branch August 11, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants