Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,6 @@
## 2026-07-30 - Add window.confirm for destructive actions
**Learning:** Destructive actions like deleting groups and edge relationships previously occurred immediately without user confirmation.
**Action:** Always wrap delete operations with window.confirm() dialogs and ensure corresponding tests successfully mock window.confirm.
## 2026-09-05 - Use aria-disabled for focusable disabled buttons
**Learning:** Using the native disabled attribute prevents focus, making descriptive hints (like aria-describedby) undiscoverable by keyboard users.
**Action:** Use aria-disabled={true} and preventDefault with inline styles for disabled buttons that require explanation.
10 changes: 8 additions & 2 deletions frontend/src/components/modals/ExportModal.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import '@testing-library/jest-dom/vitest';
import { cleanup, fireEvent, render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { afterEach, describe, expect, it, vi } from 'vitest';

import { ExportModal } from './ExportModal';
Expand Down Expand Up @@ -171,13 +172,18 @@ describe('ExportModal', () => {
expect(screen.getByRole('button', { name: '데이터 사전 Markdown 내보내기' })).toBeDisabled();
});

it('exposes access-control guidance for disabled button', () => {
it('exposes access-control guidance for disabled button', async () => {
const user = userEvent.setup();
render(<ExportModal {...baseProps} canCreateShareLink={false} />);

expect(screen.getByText('접근 권한 관리는 프로젝트 권한 설정에서 처리합니다.')).toBeInTheDocument();
const accessManagementButton = screen.getByRole('button', { name: '접근 관리' });
expect(accessManagementButton).toBeDisabled();
expect(accessManagementButton).toHaveAttribute('aria-disabled', 'true');
expect(accessManagementButton).toHaveAttribute('aria-describedby', 'share-export-access-hint');
expect(accessManagementButton).not.toHaveAttribute('title');

accessManagementButton.focus();
expect(accessManagementButton).toHaveFocus();
await user.keyboard('{Enter}');
});
});
4 changes: 3 additions & 1 deletion frontend/src/components/modals/ExportModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ export function ExportModal({
)}
<button
type="button"
disabled
aria-disabled={true}
onClick={(e) => e.preventDefault()}
style={{ opacity: 0.5, cursor: 'not-allowed' }}
aria-describedby="share-export-access-hint"
className="exportModal__disabledHintButton"
>
Expand Down
Loading