fix(a11y): use native form submission for create actions - #1078
fix(a11y): use native form submission for create actions#1078seonghobae wants to merge 5 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Current exact scope
Draft exact head
666ea85c9af5e2c3ea4d67f32a639261e67e7192onmain@8dc746920c12988f082e914879d95e13c9693535changes onlyfrontend/src/App.tsxandfrontend/src/App.nativeFormSubmission.test.tsx.The implementation converts the four create-action wrappers to native
<form>submission and changes their action buttons totype="submit". Existing async guards (isCreatingProject,isCreatingConnection,isCreatingSnapshot) and disabled states remain the product authority; this PR does not add a second click handler or synthetic submit path.The focused Vitest/Testing Library regression exercises Enter submission for sidebar project/connection/snapshot creation and the projects-page inline create form, and checks single invocation for the exercised action. This is component-level behavior evidence, not a real-browser accessibility or responsive-layout receipt.
Evidence boundary
Do not claim browser-complete keyboard accessibility from JSDOM alone. A material UI promotion still requires current-head browser evidence covering at least:
The snapshot button now lives inside
.field, whose existing layout is column/flex with spacing; the patch also adds an inlinemarginTop. Treat final spacing as visual evidence pending rather than assuming parity from source alone.Delivery Gate
Remain Draft. Do not transfer predecessor results, use forced clicks as browser evidence, weaken gates, self-approve, or merge until the unchanged exact head has terminal required checks and the material UI evidence above is satisfied.