Skip to content

🛡️ Sentinel: [MEDIUM] Add missing control character validation in Pydantic schemas #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

🛡️ Sentinel: [MEDIUM] Add missing control character validation in Pydantic schemas #1077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions backend/app/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ class IndexRedundancyOut(BaseModel):
class DiagramViewCreateIn(BaseModel):
"""Request body for saving an ERD canvas view."""

name: str = Field(min_length=1, max_length=200)
name: str = Field(
min_length=1, max_length=200, pattern=r"^[^\x00-\x1F\x7F]+$"
)
# Opaque client layout (node positions, hidden tables, viewport). The API
# bounds the serialized size in the endpoint to prevent abuse.
layout_json: dict
Expand All @@ -214,8 +216,12 @@ class DiagramViewDetailOut(DiagramViewOut):
class TableAnnotationUpsertIn(BaseModel):
"""Request body for creating/updating a table annotation."""

schema_name: str = Field(min_length=1, max_length=255)
relation_name: str = Field(min_length=1, max_length=255)
schema_name: str = Field(
min_length=1, max_length=255, pattern=r"^[^\x00-\x1F\x7F]+$"
)
relation_name: str = Field(
min_length=1, max_length=255, pattern=r"^[^\x00-\x1F\x7F]+$"
)
body: str = Field(min_length=1, max_length=10_000)


Expand Down Expand Up @@ -302,7 +308,9 @@ class DbmlConvertOut(BaseModel):
class ApiKeyCreateIn(BaseModel):
"""Request body for creating an API key."""

key_name: str = Field(min_length=1, max_length=128)
key_name: str = Field(
min_length=1, max_length=128, pattern=r"^[^\x00-\x1F\x7F]+$"
)


class ApiKeyOut(BaseModel):
Expand Down
Loading