Skip to content

fix(a11y): clarify table-edit modal close control #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −2
Draft

fix(a11y): clarify table-edit modal close control #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
938627e
🎨 Palette: 테이블 편집 모달 닫기 버튼 접근성 개선
seonghobae Sep 3, 2026
8a9de79
🎨 Palette: 테이블 편집 모달 닫기 버튼 접근성 개선
seonghobae Sep 4, 2026
10bf159
docs(ui): document table edit modal contract
seonghobae Sep 4, 2026
167905b
🎨 Palette: 테이블 편집 모달 닫기 버튼 접근성 개선
seonghobae Sep 4, 2026
c8ccd04
🎨 Palette: 테이블 편집 모달 닫기 버튼 접근성 개선
seonghobae Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/modals/EditTableModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function EditTableModal({
<div className="modal" style={{ width: 800, maxWidth: "90vw", maxHeight: "90vh", display: "flex", flexDirection: "column" }} role="dialog" aria-modal="true" aria-labelledby="edit-table-title" ref={dialogRef} tabIndex={-1}>
<div className="modal__header">
<h3 id="edit-table-title">테이블 편집</h3>
<button type="button" aria-label="닫기" onClick={onEditTableCancel}>X</button>
<button type="button" aria-label="테이블 편집 닫기" onClick={onEditTableCancel}>X</button>
</div>
<div style={{ overflowY: "auto", padding: "0 4px", flex: 1 }}>
<form id="editTableForm" onSubmit={onEditTableSubmit} className="col" style={{ gap: 12 }}>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/modals/ModalCoverage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ describe('modal behavior coverage', () => {
})
expect(duplicated.data.columns).not.toBe(tableNode.data.columns)
fireEvent.click(screen.getByRole('button', { name: '취소' }))
fireEvent.click(screen.getByRole('button', { name: '닫기' }))
fireEvent.click(screen.getByRole('button', { name: '테이블 편집 닫기' }))
expect(onSubmit).toHaveBeenCalledOnce()
expect(onDeleteTable).toHaveBeenCalledOnce()
expect(onCancel).toHaveBeenCalledTimes(3)
Expand Down
Loading