Skip to content

fix(a11y): keep export access guidance discoverable when unavailable #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix(a11y): keep export access guidance discoverable when unavailable #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5c74d95
🎨 Palette: [접근성] 내보내기 모달 내 비활성화된 버튼 발견성 개선
seonghobae Sep 3, 2026
da9c70b
🎨 Palette: [접근성] 내보내기 모달 내 비활성화된 버튼 발견성 개선
seonghobae Sep 4, 2026
242fce5
test(a11y): prove aria-disabled export control blocks activation
seonghobae Sep 4, 2026
0f249ee
docs(changelog): record export access guidance accessibility
seonghobae Sep 4, 2026
23ea7bc
fix(changelog): preserve existing release-note facts
seonghobae Sep 4, 2026
5c9a52f
docs(frontend): record export access guidance accessibility
seonghobae Sep 4, 2026
7132575
docs(a11y): keep export decision local to product evidence
seonghobae Sep 4, 2026
6cc2082
🎨 Palette: [접근성] 내보내기 모달 내 비활성화된 버튼 발견성 개선
seonghobae Sep 4, 2026
2a27bb8
🎨 Palette: [접근성] 내보내기 모달 내 비활성화된 버튼 발견성 개선
seonghobae Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion frontend/src/components/modals/ExportModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ describe('ExportModal', () => {

expect(screen.getByText('접근 권한 관리는 프로젝트 권한 설정에서 처리합니다.')).toBeInTheDocument();
const accessManagementButton = screen.getByRole('button', { name: '접근 관리' });
expect(accessManagementButton).toBeDisabled();
expect(accessManagementButton).toHaveAttribute('aria-disabled', 'true');
accessManagementButton.focus();
expect(accessManagementButton).toHaveFocus();
Comment thread
coderabbitai[bot] marked this conversation as resolved.
expect(accessManagementButton).toHaveAttribute('aria-describedby', 'share-export-access-hint');
expect(accessManagementButton).not.toHaveAttribute('title');
});
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/components/modals/ExportModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,8 @@ export function ExportModal({
)}
<button
type="button"
disabled
aria-disabled={true}
onClick={(e) => e.preventDefault()}
Comment thread
seonghobae marked this conversation as resolved.
aria-describedby="share-export-access-hint"
className="exportModal__disabledHintButton"
>
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,8 @@ button:disabled {
}

.exportModal__disabledHintButton {
opacity: 0.9;
opacity: 0.5;
cursor: not-allowed;
}

.exportModal__hint {
Expand Down
Loading