-
Notifications
You must be signed in to change notification settings - Fork 0
๐จ Palette: [์ ๊ทผ์ฑ ๊ฐ์ ] ExportModal ๋ด ๋นํ์ฑ ๋ฒํผ์ ๋ํ ํค๋ณด๋ ๋ฐ ํ๋ฉด ํ๋ ๊ธฐ ์ ๊ทผ์ฑ ํฅ์ #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
16
commits into
main
Choose a base branch
from
palette-aria-disabled-export-modal-3222162209141896517
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
โ4
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3e812aa
๐จ Palette: [์ ๊ทผ์ฑ] ๋ด๋ณด๋ด๊ธฐ ๋ชจ๋ฌ์ '์ ๊ทผ ๊ด๋ฆฌ' ๋นํ์ฑํ ๋ฒํผ ํฌ์ปค์ค ์ด๋ ์ง์
seonghobae 38e1906
๐จ Palette: [์ ๊ทผ์ฑ] ๋ด๋ณด๋ด๊ธฐ ๋ชจ๋ฌ์ '์ ๊ทผ ๊ด๋ฆฌ' ๋นํ์ฑํ ๋ฒํผ ํฌ์ปค์ค ์ด๋ ์ง์
seonghobae 65eb555
chore: stop work as requested
seonghobae 18f87f1
chore: trigger CI retry
seonghobae 927980e
chore: trigger CI retry again
seonghobae dd99ce5
chore: trigger CI retry again 2
seonghobae e39b57f
chore: trigger CI retry again 3
seonghobae b9c6c11
chore(palette): restore repository guidance
seonghobae 5ccfe4c
test(export): assert aria-disabled activation suppression
seonghobae 3f8e2d1
docs(changelog): record accessible disabled hint contract
seonghobae f85c708
chore(palette): restore exact protected guidance blob
seonghobae 9db986a
chore: trigger CI retry again 4
seonghobae 09f7bc6
chore(ui): keep ExportModal accessibility decision local
seonghobae 45c22cf
chore: trigger CI retry again 5
seonghobae ba8eb8a
chore: trigger CI retry again 6
seonghobae a95cac5
chore: trigger CI retry again 7
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ Maintainability & Code Quality | ๐ก Minor | โก Quick win
ํญ ์์์ Enter ์ฐจ๋จ์ ์ง์ ๊ฒ์ฆํ์ธ์.
accessManagementButton.focus()๋ ํ๋ก๊ทธ๋๋ฐ ๋ฐฉ์์ ํฌ์ปค์ค๋ง ํ์ธํฉ๋๋ค. ๋ฒํผ์ด Tab ์์์์ ์ ์ธ๋์ด๋ ํ ์คํธ๊ฐ ํต๊ณผํ ์ ์์ต๋๋ค.Enter ํ
toHaveFocus()๋ง ํ์ธํด๋onClick={(e) => e.preventDefault()}์ ๊ฑฐ๋ฅผ ๊ฐ์งํ์ง ๋ชปํฉ๋๋ค. ํ์ฌ ๋ฒํผ์type="button"์ด๊ณ ๋ณ๋ ๋์ ์ฝ๋ฐฑ๋ ์์ผ๋ฏ๋ก ํฌ์ปค์ค๊ฐ ๊ทธ๋๋ก ์ ์ง๋ฉ๋๋ค.user.tab()์ผ๋ก ์ด์ ์ปจํธ๋กค์์ ๋ฒํผ๊น์ง ์ด๋ํ๋์ง ํ์ธํ๊ณ , ์ทจ์ ๊ฐ๋ฅํclick์ด๋ฒคํธ์defaultPrevented๋ฅผ ๋จ์ธํ์ธ์.ํ๊ท ํ ์คํธ ๋ณด๊ฐ ์์
As per coding guidelines, behavior changes require focused tests.
๐ Committable suggestion
๐ค Prompt for AI Agents
Source: Coding guidelines