refactor(db): use semantic pooler probe identifiers - #1058
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Canonical bounded naming repair for the private PgBouncer/PgCat admin-console probe on protected
main@8dc746920c12988f082e914879d95e13c9693535.The verified defect was an organization-owned private nested helper
_run()plus generic connection/query locals (dsn,password,conn,cur,row) inside the database-pooler detection boundary. The surrounding product context already supplies unambiguous bounded vocabulary: pooler probe, pooler admin console, and version row.TDD lineage
9efcdbf28476be4f0f81162b37ea93bb952567d4: AST contract requires_run_pooler_probeand semantic pooler connection/query identifiers while rejecting the old generic names. Exact protected base has_run,dsn,password,conn,cur, androw, so the regression corresponds to the current defect.be55ea51c32fc73990ddf3870b797ee5bf029e0a:_run→_run_pooler_probe,dsn→pooler_dsn,password→pooler_password,conn→pooler_connection,cur→pooler_cursor,row→version_row, with all private callers updated in the same change.Compatibility / persistence
No public FastAPI dependency, SQLAlchemy engine/session symbol, configuration key, PostgreSQL schema/table/column/index/constraint, Alembic migration, DSN wire format, pooler protocol command, read/write routing behavior, timeout, locking, or persistence behavior changes.
SHOW VERSION;and the publicget_pooler_detection()contract are unchanged.No database migration, FK/index rebuild, ORM remap, UPSERT change, hot-partition change, rollback transform, or read/write-topology change is required for this private-identifier repair.
Verification boundary
Fresh exact-head backend/security/review evidence is required. Historical base or predecessor evidence does not transfer. Keep Draft until the unchanged final head has all live required checks terminal-success, valid findings/threads resolved, qualifying independent approval where required, and ordinary protected-branch governance permits merge.