Skip to content

superseded: exported option validation consolidated in #126 - #94

Closed
seonghobae wants to merge 6 commits into
masterfrom
sentinel-strict-input-validation-17572767824911866375
Closed

superseded: exported option validation consolidated in #126#94
seonghobae wants to merge 6 commits into
masterfrom
sentinel-strict-input-validation-17572767824911866375

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #126

Fresh effective-delta audit at fab122ef7ef75a5ca60c80cc300d380f1c8dbd85 confirms this lane contributes the same three option-domain checks now owned by canonical Draft #126@4af198147f33a83cb62d1e66f6d95eaf2b06d838: scalar non-missing logical nested, scalar adj in none|aic|bic, and scalar numeric conf.level strictly inside (0,1), all before model inspection and with package-owned call. = FALSE errors.

#126 carries a stronger executable contract across NA/NULL/wrong type/vector/boundary values, empty and whitespace-padded adjustment names, exact messages, and conditionCall(err) == NULL. No unique test, fixture, statistical semantic, or release evidence remains only here.

The generated .jules/sentinel.md prescription and MEDIUM/information-leak severity framing are intentionally not inherited: the demonstrated evidence establishes deterministic exported-input/error behavior, not a deployment-specific exploit or severity rating.

Every valid semantic/evidence delta from this PR is therefore represented in #126. This closure transfers neither GREEN status nor merge authority.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 53 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 82fbf53b-2f7f-47a6-84ec-3b1942c4e704

📥 Commits

Reviewing files that changed from the base of the PR and between e910437 and 79e9761.

📒 Files selected for processing (3)
  • NEWS
  • R/vuongtest.R
  • tests/testthat/test_vuongtest_errors.R

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d2511bcd-b88f-46f1-ba09-5ff015a8628e

📥 Commits

Reviewing files that changed from the base of the PR and between 807e940 and e910437.

📒 Files selected for processing (4)
  • .jules/sentinel.md
  • R/icci.R
  • R/vuongtest.R
  • tests/testthat/test_vuongtest_errors.R

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

icci()vuongtest()가 잘못된 입력을 즉시 검증하고 call. = FALSE 오류를 반환합니다. 각 검증 조건을 확인하는 테스트와 보안 학습 기록을 추가했습니다.

Changes

입력 인자 검증

Layer / File(s) Summary
함수 인자 검증 및 오류 테스트
R/icci.R, R/vuongtest.R, tests/testthat/test_vuongtest_errors.R, .jules/sentinel.md
icci()conf.level의 형식과 범위를 검증합니다. vuongtest()nestedadj의 형식, 길이, 허용 값을 검증합니다. 잘못된 입력에 대한 오류와 call. = FALSE 동작을 테스트합니다. 보안 학습 기록에 검증 지침을 추가했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e9104

The change makes invalid arguments to vuongtest() and icci() fail with explicit errors instead of raw internal failures. This is a localized behavior improvement with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 vuongtest()icci()의 입력 검증 누락 수정이라는 주요 변경 사항을 정확하게 요약합니다. 보안 심각도와 방패 이모지는 부가 정보이지만 제목의 명확성을 해치지 않습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sentinel-strict-input-validation-17572767824911866375

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@opencode-agent opencode-agent Bot added priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: maintenance Maintenance, build, dependency, or operational upkeep labels Aug 22, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 new potential issues.

Devin Review

@seonghobae seonghobae changed the title 🛡️ Sentinel: [MEDIUM] Fix input validation missing in vuongtest and icci superseded: exported option validation consolidated in #126 Sep 6, 2026
@seonghobae seonghobae closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: maintenance Maintenance, build, dependency, or operational upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant