Skip to content

superseded: lavaan type-stable row-count change consolidated in #90 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 3 commits into from
Closed

superseded: lavaan type-stable row-count change consolidated in #90 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbef762
⚡ Bolt: Optimize list iteration with vapply
seonghobae Sep 1, 2026
85b95b1
⚡ Bolt: Optimize list iteration with vapply
seonghobae Sep 1, 2026
7b9d3a8
⚡ Bolt: Optimize list iteration with vapply
seonghobae Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@
## 2024-05-15 - [R Performance: ifelse Overhead]
**Learning:** In R, ifelse evaluates both true and false branches entirely before subsetting, which is very inefficient for vector operations.
**Action:** Optimize this by preallocating with res <- Y * 0 to preserve attributes and using vectorized subsetting like if any cond res subset <- ...
## 2026-09-01 - Avoid sapply overhead on lists
**Learning:** In R codebases, using `sapply` over a list involves significant overhead to deduce and simplify the return type.
**Action:** When the return type and length are known, prefer `vapply(..., FUN.VALUE = type)` over `sapply(...)` for better performance and safety.
3 changes: 2 additions & 1 deletion R/llcont.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,8 @@ llcont.lavaan <- function(x, ...){
if(tolower(lavInspect(x, "options")$missing) == "ml.x") stop("cannot handle lavaan models with missing='ml.x'. consider using missing='ml'.", call. = FALSE)
mispatts <- lavInspect(x, "patterns")
if(any(class(mispatts) == "list")){
npatts <- max(sapply(mispatts, nrow))
## Bolt: replaced sapply with vapply to avoid type deduction overhead
npatts <- max(vapply(mispatts, nrow, numeric(1)))

@devin-ai-integration devin-ai-integration Bot Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Numeric template preserves row counts

vapply safely promotes integer results from nrow to the numeric template. The maximum and subsequent missing-data validation remain unchanged.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

} else {
npatts <- nrow(mispatts)
}
Expand Down
Loading