superseded: exported option validation consolidated in #126 - #109
superseded: exported option validation consolidated in #126#109seonghobae wants to merge 2 commits into
Conversation
Added strict type, length, and bounds validation at the beginning of exported functions to fail securely using stop(..., call. = FALSE).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes입력 검증 강화
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change adds bounded validation for invalid arguments so users receive clear errors instead of internal execution failures; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (length(conf.level) != 1 || !is.numeric(conf.level) || is.na(conf.level) || conf.level <= 0 || conf.level >= 1) { | ||
| stop("The 'conf.level' argument must be a single numeric value between 0 and 1.", call. = FALSE) | ||
| } |
There was a problem hiding this comment.
🔍 Validation change omitted from changelog
The new exported argument errors change user-visible behavior, but NEWS contains no entry. Repository conventions require one.
Was this helpful? React with 👍 or 👎 to provide feedback.
| if (length(nested) != 1 || !is.logical(nested) || is.na(nested)) { | ||
| stop("The 'nested' argument must be a single logical value (TRUE or FALSE).", call. = FALSE) | ||
| } | ||
| if (length(adj) != 1 || !is.character(adj) || !(adj %in% c("none", "aic", "bic"))) { | ||
| stop("The 'adj' argument must be a single string ('none', 'aic', or 'bic').", call. = FALSE) | ||
| } |
There was a problem hiding this comment.
🔍 Validation lacks regression coverage
No tests exercise the new scalar, missing-value, membership, or boundary checks. Later changes can silently weaken these exported input guarantees.
Was this helpful? React with 👍 or 👎 to provide feedback.
Added strict type, length, and bounds validation at the beginning of exported functions to fail securely using stop(..., call. = FALSE).
seonghobae
changed the title
1 participant
Superseded by #126
Fresh exact-head audit at
b8502ac1dfcf4833e549fdee81c321c2b07a680aconfirms this branch contains the same three exported option-domain checks now owned by Draft #126@4af198147f33a83cb62d1e66f6d95eaf2b06d838: scalar non-missing logicalnested, scalar supported adjustment name, and scalar numericconf.levelinside(0,1)before model evaluation.#126 carries a stronger persistent exported-boundary regression across NA/NULL/wrong type/vector/bounds, empty and whitespace-padded adjustment values, exact package-owned messages, and null condition calls. No unique test, statistical contract, fixture, or release evidence remains only here.
The branch-local
.jules/sentinel.mdgeneralization and MEDIUM/information-leak claim are not inherited because the demonstrated behavior supports deterministic input/error handling, not that deployment-specific severity assertion.Every valid semantic delta is fully represented in #126. This closure transfers neither GREEN status nor merge authority.