Skip to content

⚑ Bolt: Replace sapply with vapply in llcont.lavaan #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

⚑ Bolt: Replace sapply with vapply in llcont.lavaan #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@
## 2024-05-15 - [R Performance: ifelse Overhead]
**Learning:** In R, ifelse evaluates both true and false branches entirely before subsetting, which is very inefficient for vector operations.
**Action:** Optimize this by preallocating with res <- Y * 0 to preserve attributes and using vectorized subsetting like if any cond res subset <- ...
## 2026-03-31 - [Optimize sapply to vapply for performance and safety]
**Learning:** In R codebases, using `sapply` over a list involves significant overhead to deduce and simplify the return type. When the return type and length are known, prefer `vapply(..., FUN.VALUE = type)` over `sapply(...)` for better performance and safety.
**Action:** Replace `sapply` with `vapply(..., FUN.VALUE = numeric(1))` when calculating row lengths in `llcont.lavaan` (in `R/llcont.R`).
3 changes: 2 additions & 1 deletion R/llcont.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,8 @@ llcont.lavaan <- function(x, ...){
if(tolower(lavInspect(x, "options")$missing) == "ml.x") stop("cannot handle lavaan models with missing='ml.x'. consider using missing='ml'.", call. = FALSE)
mispatts <- lavInspect(x, "patterns")
if(any(class(mispatts) == "list")){
npatts <- max(sapply(mispatts, nrow))
## Bolt: replaced sapply with optimized vapply for performance
npatts <- max(vapply(mispatts, nrow, numeric(1)))

@devin-ai-integration devin-ai-integration Bot Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ“ Info: vapply template safe for integer nrow

nrow returns integer and vapply(..., numeric(1)) accepts it via integer-to-double coercion. max() and the npatts > 1 check behave as before, so this is behavior-preserving.

Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

} else {
npatts <- nrow(mispatts)
}
Expand Down
Loading