fix(toolchain): replace Wrangler/Miniflare GPL-family path - #540
fix(toolchain): replace Wrangler/Miniflare GPL-family path#540seonghobae wants to merge 39 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Regenerate package-lock.json with the exact pinned toolchain (Node.js 24.19.0 / npm 11.17.0) to remove the remaining Wrangler/Miniflare/Sharp/Libvips (LGPL-3.0) dependency path the PR description flagged as the last causal gap. Verified byte-identical to the lockfile-reproducibility workflow's own fresh-directory regeneration. Repair three test fixtures that had drifted from already-correct production changes on this branch, each confirmed against a Node 24.19.0/npm 11.17.0 run: - test/upload-artifact-node24-integrity.test.ts: add the new lockfile-reproducibility.yml workflow to the reviewed upload-artifact inventory (its two uses already pin the reviewed SHA). - test/patch-validator-image-contract.test.ts: match the current multi-line `npm pkg delete` block, which now also strips workerd and esbuild (added by this PR) from the validator image, plus the corresponding node_modules absence checks. - test/cloudflare-worker-config.test.mjs: move the "unsupported root key" fixture's new field ahead of the `[vars]` section header. TOML is section-scoped, so appending it after `[vars]` exercised the (intentionally open-ended) vars path instead of the root-key allowlist the test means to cover; the parser itself was already correct. Confirmed via `npm run typecheck` and the full `vitest` suite on the exact pinned toolchain. Remaining local failures (acquisition symlink/owner-mode checks, a SIGTERM-reaping timing test) reproduce only because this sandbox runs as root/uid 0, unlike the CI runner, and are not touched here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BV96rXhqoR3tYZ9AeAVur4
Evidence: lockfile regenerated, 3 stale test fixtures repaired —
|
|
Fresh current-head authority supersedes the stale body snapshot: protected |
|
2026-09-06 KST post-#546 repair finding: protected base is now |
Purpose and owner boundary
Replace the former Wrangler/Miniflare/Sharp development path with pinned
workerd@1.20260625.1+esbuild@0.28.1, keeping Cloudflare lifecycle truth and foreign routing/security authority outside Noema.Current protected-base repair — 2026-09-06 KST
Protected Noema is
main@e26d771470a4ece873c367b40b3cd6cb03ac7de3. Because the lockfile policy requires exact PR-base equality, the post-#527 base movement made the priorbaseSha=5b8e620...stale. Causal commit7c8c26983f5628ccf6125ed3d3cb52edc9782f9dchanges only.github/lockfile-change-policy.json.baseShatoe26d771..., preserving package/top-level digests, source URLs, target inventory and toolchain bytes. Ordinary two-parent/non-force restack6b7f0a7b8c3069a815f74ee654620e59574bd4e1then adopts merged #527 OIDC trust without weakening licensing/scanner policy.Fresh exact-head
ci 34027015120andreviewer-ci 34027015135are pending; requiredSecurity Scan 34027015129andpatch-validator-image 34027015123are queued. Predecessor results do not transfer. Keep Draft until unchanged-head terminal GREEN and clear current review state.