fix(docs-ui): scope Swagger authorization persistence to development - #811
fix(docs-ui): scope Swagger authorization persistence to development#811seonghobae wants to merge 9 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough개발 환경에서 Swagger UI가 페이지 새로고침 후 인증 토큰을 유지하도록 변경했습니다. 프로덕션에서는 해당 설정을 활성화하지 않습니다. ChangesSwagger 인증 토큰 유지
ArticleNode 스키마 변경
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Swagger UI now retains authorization only in development, while production remains unchanged. Article headlines remain required, and no current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jules continue from exact |
요청하신 피드백을 모두 반영했습니다. |
Current exact boundary
develop@e06b1f3fb10903569124af011da213951e6e2473b5e89be4919d3d446cab18a43fce0f70eb8bea51CHANGELOG.md,src/newsdom_api/main.py,tests/test_runtime_readiness.pyThis lane evaluates
persistAuthorizationonly for the development Swagger UI.create_app()adds it only whenRuntimeProfile.DEVELOPMENT; production omits the option. The current tests prove the rendered/docsconfiguration string for development vs production, but do not yet prove browser storage/refresh behavior.Intervening-scope repair
Fresh protected-base comparison showed the earlier unrelated
schemas.pycleanup had already disappeared from the effective delta. The branch-local.jules/palette.mdappendix, however, had been reintroduced and generalized this local Swagger preference into repository-wide design doctrine. Normal childb5e89be4919d3d446cab18a43fce0f70eb8bea51restores.jules/palette.mdbyte-for-byte to protecteddevelop; no force push or history rewrite was used.Browser RED → GREEN acceptance
This is a material developer-UI behavior and source-string/TestClient evidence is not sufficient for completion. Preserve the runtime-profile and authentication-readiness boundaries, then exercise the actual Swagger UI in a current browser:
Fresh exact-head CI/Security/SAST/CodeQL and qualifying independent current-head review are required before Ready/merge. Predecessor results, source-neutral re-kicks, generated doctrine, self-approval, gate weakening, force push, or destructive rebase are not acceptance evidence.
Delivery Gate