Skip to content

✨ Feature: JSONL 내보내기 도구 추가 - #810

Closed
seonghobae wants to merge 1 commit into
developfrom
feature/export-jsonl-tool-6330467667814798392
Closed

✨ Feature: JSONL 내보내기 도구 추가#810
seonghobae wants to merge 1 commit into
developfrom
feature/export-jsonl-tool-6330467667814798392

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Verified successor

이 PR의 유효 JSONL export delta는 canonical successor #791에 완전 승계했습니다.

  • predecessor exact head: 31d185c97892db1793f880d95bd45259bf84e70d
  • successor exact head: feat(export): preserve canonical NewsDOM JSONL artifacts atomically #791 10b85cce7b12b6c11d4a9817cba200fb1918e841
  • JSON input/file/extension validation, invalid-JSON error handling, UTF-8 JSONL 출력, article-per-line CLI, 성공/실패 CLI contract, tests, CHANGELOG 의미는 successor가 모두 보존합니다.
  • #791은 추가로 production ParseResponse validation, complete ArticleNode provenance, input/hard-link overwrite rejection, same-directory temp + flush/fsync + atomic replace, 실패 시 기존 destination 보존을 고정합니다.

이 PR의 malformed page/article silent skip, synthetic Unknown identifiers, canonical body_blocks/media provenance를 body_text로 축소하는 alternate schema는 NewsDOM domain truth를 보존하지 않으므로 유효 successor delta로 승계하지 않습니다. 100% 테스트 커버리지 주장도 current hosted exact-head evidence가 아니므로 승계 근거로 사용하지 않습니다.

따라서 단순 Close가 아니라 verified successor consolidation으로 종료합니다. #791은 unchanged exact-head required gates가 terminal-valid할 때까지 Draft를 유지합니다.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 74b06425-9e0d-4aa3-8d58-2aa1d259b18f

📥 Commits

Reviewing files that changed from the base of the PR and between e06b1f3 and 31d185c.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • tests/test_tools_export_jsonl.py
  • tools/export_jsonl.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T22:23:29.797394Z 31d185c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant