security(pdf): superseded by bounded parser-failure lane #789 - #799
security(pdf): superseded by bounded parser-failure lane #789#799seonghobae wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closure basis
This PR is superseded by canonical repair #789, currently at exact Git head
1b42df2b579dc1618193928a515a8ff25ae83fc6against the samedevelop@e06b1f3fb10903569124af011da213951e6e2473base.The valid security intent here is already inherited by #789 with a narrower executable contract: malformed/parser-resource failures including
PdfReadError,RecursionError,ValueError,OverflowError,TypeError, andMemoryErrorare normalized to the fixed 415 response, while an unexpectedRuntimeErroris explicitly required not to be translated into an invalid-media client error. #789 also offloads synchronousPdfReaderstructural validation and downstream PDF parsing from the ASGI event-loop thread.This PR adds only a broad
except Exceptionplus error-level traceback logging and a journal rule instructing future code to catch every exception around complex file parsers. That is not an additional valid security delta: it masks programming/runtime defects as attacker-caused 415 responses, weakens incident classification, and can amplify malformed-input log volume. The specificTypeError/MemoryErrorcases claimed here are already present in #789's explicit taxonomy and tests.Closure class: verified successor / no additional valid semantic delta. Preserve #789's explicit exception taxonomy, fixed non-secret warning/error surface, event-loop offload regression, and exact-head hosted gates. Reopen only if a concrete parser exception is reproduced that is absent from the bounded taxonomy; add that exception with a focused RED rather than restoring
except Exception.