Skip to content

chore(a11y): preserve conflicting generated Settings lineage - #1581

Draft
seonghobae wants to merge 6 commits into
developfrom
palette/a11y-aria-disabled-12394734136752475048
Draft

chore(a11y): preserve conflicting generated Settings lineage#1581
seonghobae wants to merge 6 commits into
developfrom
palette/a11y-aria-disabled-12394734136752475048

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Lifecycle repair

This generated direct-develop PR is preserved as provenance but is no longer an active Naruon source writer.

  • protected base: develop@042b0c70531b229af3acbd0421a2f23098d848b3
  • generated head: 4b62eaf1b9ac90529b60eca0c4a1293961180059
  • current exact head: 407f4385535907e5c9a6603a5e2a074f39cdd1e5
  • lifecycle: open / Draft / mergeable / zero effective delta
  • current head is an ordinary non-force child of the generated commit and adopts the exact protected develop tree 8fde14381aaa430eeaaf61151dab6f6800127cd3; GitHub reports 0 changed files / 0 additions / 0 deletions.

Why the generated delta is not product authority

The generated commit removed aria-disabled from two native-disabled Settings buttons and added a blanket .jules/palette.md rule saying loading controls should avoid redundant aria-disabled.

The narrow statement that native disabled already exposes disabled state is valid for a native-disabled control, but it is not a repository-wide interaction rule. Naruon also intentionally uses focusable aria-disabled controls when an unavailable action must stay keyboard-reachable and expose the reason it cannot run. Existing Settings accessibility lanes #1452/#1453 already own the broader disabled-action/reason contract, while #1561 owns the analogous focusable unavailable-action pattern for NetworkGraph. A new generated direct-develop PR with no focused regression must not silently redefine those contracts.

The generated .jules guidance is therefore rejected as over-broad, and the two-line Settings cleanup is not retained as a parallel source writer. The historical commit remains in ancestry for provenance. No force-push, destructive rebase, self-approval, dummy/no-op requeue, or gate weakening was used.

Succession boundary

Do not close this PR merely because its effective delta is now zero. Keep it open Draft until the existing Settings accessibility lanes are reconciled through one canonical owner and a fresh protected-target equivalence audit proves whether these two native-disabled controls should retain native-only disabled semantics or participate in the focusable unavailable-action contract. Only then may the historical generated contribution be declared fully superseded or deliberately rejected and this lineage closed.

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Preserve the generated aria-disabled cleanup in ancestry but restore the protected develop tree. The generated .jules rule is too broad for Naruon's focusable aria-disabled patterns, and Settings disabled-action accessibility is already owned by existing Settings lanes. No product delta is retained here.
@seonghobae
seonghobae marked this pull request as draft September 7, 2026 01:56
@seonghobae seonghobae changed the title 🎨 Palette: [접근성 개선] 중복된 aria-disabled 속성 제거 chore(a11y): preserve conflicting generated Settings lineage Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

DESIGN ASSURANCE — exact head 4b62eaf1b9ac90529b60eca0c4a1293961180059

Removing redundant aria-disabled from native disabled buttons is a bounded, standards-aligned source change; the existing disabled and operation-scoped aria-busy remain. I found no source-level regression in the two production hunks.

This head is not merge-ready: the centralized dependency-review, Trivy, OSV, Semgrep, Scorecard, OpenCode, Noema, coverage and admission jobs were cancelled, while image validation was still running. CodeQL/Bandit success alone is not exact-head admission. The added .jules/palette.md entry is also dated 2024-05-25 despite being created in the 2026 change and should not become general doctrine before actual assistive-technology evidence.

Owner acceptance: keep the source delta, repair/remove the stale doctrine entry, and prove the saving/rotation buttons’ disabled→busy→success/failure lifecycle with pointer, keyboard, focus, programmatic re-entry and real accessibility-tree evidence on this exact successor head; then rerun all required current-head gates. I left the dedicated writer’s source, lifecycle and refs unchanged.

@google-labs-jules

Copy link
Copy Markdown
Contributor

DESIGN ASSURANCE — exact head 4b62eaf1b9ac90529b60eca0c4a1293961180059

Removing redundant aria-disabled from native disabled buttons is a bounded, standards-aligned source change; the existing disabled and operation-scoped aria-busy remain. I found no source-level regression in the two production hunks.

This head is not merge-ready: the centralized dependency-review, Trivy, OSV, Semgrep, Scorecard, OpenCode, Noema, coverage and admission jobs were cancelled, while image validation was still running. CodeQL/Bandit success alone is not exact-head admission. The added .jules/palette.md entry is also dated 2024-05-25 despite being created in the 2026 change and should not become general doctrine before actual assistive-technology evidence.

Owner acceptance: keep the source delta, repair/remove the stale doctrine entry, and prove the saving/rotation buttons’ disabled→busy→success/failure lifecycle with pointer, keyboard, focus, programmatic re-entry and real accessibility-tree evidence on this exact successor head; then rerun all required current-head gates. I left the dedicated writer’s source, lifecycle and refs unchanged.

Thank you for the review. I have removed the stale/unverified doctrine entry regarding aria-disabled from .jules/palette.md as requested, keeping the source modifications intact. Ready for the next verification round.

@seonghobae seonghobae added maintenance type: maintenance Maintenance, build, dependency, or operational upkeep labels Sep 7, 2026 — with ChatGPT Codex Connector
@seonghobae seonghobae added the priority: high High-priority or P1 work label Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance priority: high High-priority or P1 work type: maintenance Maintenance, build, dependency, or operational upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant