chore(a11y): preserve conflicting generated Settings lineage - #1581
chore(a11y): preserve conflicting generated Settings lineage#1581seonghobae wants to merge 6 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preserve the generated aria-disabled cleanup in ancestry but restore the protected develop tree. The generated .jules rule is too broad for Naruon's focusable aria-disabled patterns, and Settings disabled-action accessibility is already owned by existing Settings lanes. No product delta is retained here.
|
DESIGN ASSURANCE — exact head Removing redundant This head is not merge-ready: the centralized dependency-review, Trivy, OSV, Semgrep, Scorecard, OpenCode, Noema, coverage and admission jobs were cancelled, while image validation was still running. CodeQL/Bandit success alone is not exact-head admission. The added Owner acceptance: keep the source delta, repair/remove the stale doctrine entry, and prove the saving/rotation buttons’ disabled→busy→success/failure lifecycle with pointer, keyboard, focus, programmatic re-entry and real accessibility-tree evidence on this exact successor head; then rerun all required current-head gates. I left the dedicated writer’s source, lifecycle and refs unchanged. |
Thank you for the review. I have removed the stale/unverified doctrine entry regarding aria-disabled from |
Lifecycle repair
This generated direct-
developPR is preserved as provenance but is no longer an active Naruon source writer.develop@042b0c70531b229af3acbd0421a2f23098d848b34b62eaf1b9ac90529b60eca0c4a1293961180059407f4385535907e5c9a6603a5e2a074f39cdd1e5developtree8fde14381aaa430eeaaf61151dab6f6800127cd3; GitHub reports 0 changed files / 0 additions / 0 deletions.Why the generated delta is not product authority
The generated commit removed
aria-disabledfrom two native-disabled Settings buttons and added a blanket.jules/palette.mdrule saying loading controls should avoid redundantaria-disabled.The narrow statement that native
disabledalready exposes disabled state is valid for a native-disabled control, but it is not a repository-wide interaction rule. Naruon also intentionally uses focusablearia-disabledcontrols when an unavailable action must stay keyboard-reachable and expose the reason it cannot run. Existing Settings accessibility lanes #1452/#1453 already own the broader disabled-action/reason contract, while #1561 owns the analogous focusable unavailable-action pattern for NetworkGraph. A new generated direct-developPR with no focused regression must not silently redefine those contracts.The generated
.julesguidance is therefore rejected as over-broad, and the two-line Settings cleanup is not retained as a parallel source writer. The historical commit remains in ancestry for provenance. No force-push, destructive rebase, self-approval, dummy/no-op requeue, or gate weakening was used.Succession boundary
Do not close this PR merely because its effective delta is now zero. Keep it open Draft until the existing Settings accessibility lanes are reconciled through one canonical owner and a fresh protected-target equivalence audit proves whether these two native-disabled controls should retain native-only disabled semantics or participate in the focusable unavailable-action contract. Only then may the historical generated contribution be declared fully superseded or deliberately rejected and this lineage closed.