fix(security): redact prompt provider exception details - #1563
seonghobae wants to merge 12 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 943abe397f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
Connect the fixed-event logging contract and sentinel regression to OWASP and NIST guidance without copying an unverified external binary. Assisted-by: OpenAI Codex Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Restacked without force on #1565 exact head |
Acknowledged. |
문제
provider 예외에서 문자열 보간만 없애고
exc_info=True를 남기면 Python traceback이 예외 메시지를 기록합니다. API 키, Authorization 헤더, 내부 URI, 고객 프롬프트가 애플리케이션 로그 경계를 넘을 수 있습니다. provider 호출 실패 뒤 client cleanup까지 실패하면finally예외가 고정 502 응답을 덮어쓰는 문제도 있었습니다.RED → 근본 수리
docs/doctoring/prompt-provider-error-boundary.md에 OWASP Logging Cheat Sheet와 NIST SP 800-92 근거, cleanup 경계를 기록했습니다.Stack과 exact authority
develop@042b0c70531b229af3acbd0421a2f23098d848b352dfc863d1a5d6e4e80b6366f719dd09f2aa6172b1169e26949e7f75ebdccbdb9bb1f07eeacc163b2e9e1a28b08c53092e47193685347c8648a3dec9#1565를 non-force merge하고 그 branch로 retarget했습니다. 의존성 manifest를 이 PR에서 복제하지 않으며, effective child delta는 prompt 예외 경계의 구현·회귀 테스트·doctoring뿐입니다.
검증
병합 경계
#1565가 먼저 보호 병합되고, 이 PR을 최신 보호 base에 non-force restack한 뒤 unchanged exact head의 모든 필수 Check와 독립 승인, 미해결 finding 0건을 다시 확인합니다. predecessor 증거 이전, self-approval, force push, admin bypass, dummy commit, traceback 복원은 금지합니다.
The current head non-force merges the parent runtime/provenance follow-up while preserving this child at three effective files. Parent and child hosted evidence remain independent.