Skip to content

chore: remove stray scratch/debug files committed to develop - #1450

Open
seonghobae wants to merge 5 commits into
developfrom
chore/remove-stray-scratch-files
Open

chore: remove stray scratch/debug files committed to develop#1450
seonghobae wants to merge 5 commits into
developfrom
chore/remove-stray-scratch-files

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Current exact-head state — 2026-09-07

  • protected base: develop@042b0c70531b229af3acbd0421a2f23098d848b3
  • exact head: 3f8b0cdafcba27d595fd13c125457bbf4b8df484
  • lifecycle: Ready for independent review / mergeable / not merge-ready
  • effective delta: four root-level scratch artifacts removed, 92 deletions, no production behavior intended

This PR removes plan.md, test_parse.py, test_parse2.py, and test_parse3.py. The historical description also named frontend/src/components/NetworkGraph.tsx.out, but that path is not part of the current exact-head diff. The test_parse*.py files are one-off text_safety debugging scripts that mutate sys.path and call internal helpers outside the repository's normal backend/tests/ ownership.

Current evidence

Repository-owned exact-head workflows are terminal-success for Application CI 33607711416, Security Scan 33607710995, SAST Semgrep 33607711068, Bandit 33607711130, Dependency Review 33607711125, and Docker 33607711489. The exact-head coverage-evidence check is also terminal-success.

All inline review threads are clear. Existing Devin submissions are COMMENTED; its later MIME percent-decoding note is outside this four-file cleanup delta and remains owned by the attachment-parser repair lane rather than being copied here.

The remaining required central evidence is not GREEN on this unchanged head: strix is completed/cancelled, noema-review is completed/failure, and opencode-review is completed/cancelled. Those historical exact-head results came from central owner controls that have since changed; they are not Naruon source findings and they are not passing evidence.

This PR was moved from Draft to Ready for independent review without changing the source SHA so review admission is no longer blocked by Draft state. Ready is not merge authorization. A fresh central evaluation or qualifying current-head approval must still occur, and every then-live required gate must be satisfied on this same exact head before merge.

Do not create a no-op requeue commit, transfer predecessor evidence, self-approve, dismiss reviews, weaken protection, or use admin/bypass merge.

plan.md, test_parse.py, test_parse2.py, test_parse3.py, and
frontend/src/components/NetworkGraph.tsx.out are ad-hoc planning notes,
manual debug scripts, and a stray build-output copy that were accidentally
committed to the protected default branch. None are referenced by the
backend/frontend test suites or CI. Removing them also stops every
still-open PR whose branch predates their addition from showing a
misleading 'this PR deletes N files' diff against develop (e.g. #1287).
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: d9c9569c-54a5-43a9-8ece-e2f7549035fe

📥 Commits

Reviewing files that changed from the base of the PR and between 042b0c7 and 3f8b0cd.

📒 Files selected for processing (4)
  • plan.md
  • test_parse.py
  • test_parse2.py
  • test_parse3.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@opencode-agent opencode-agent Bot added priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: maintenance Maintenance, build, dependency, or operational upkeep labels Aug 22, 2026
@seonghobae
seonghobae enabled auto-merge (squash) August 24, 2026 00:26
@opencode-agent
opencode-agent Bot disabled auto-merge August 31, 2026 06:43

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ Literal percent sequences corrupt attachment names

When an attachment name contains URL-like percent text, unquote decodes it although MIME filenames are already decoded. Names can truncate at decoded slashes or select the wrong parser.

Devin Review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for 3f8b0cdafcba27d595fd13c125457bbf4b8df484:

  • Draft PR: merge automation is paused.
  • Required check opencode-review is CANCELLED on the current head.
  • Required check strix is CANCELLED on the current head.

Copy link
Copy Markdown
Contributor Author

Supersession provenance update (2026-09-03): #1523 has been closed only after exact comparison proved its entire valid delta is carried here. Both PRs were based on develop@042b0c70531b229af3acbd0421a2f23098d848b3; #1523 changed only test_parse3.py, and that deletion patch is byte-identical to this PR's test_parse3.py deletion. This PR additionally removes plan.md, test_parse.py, and test_parse2.py.

No #1523 check/review evidence transfers to this head. #1450 remains subject to fresh exact-head protected checks, review-thread state, and qualifying post-last-push approval before merge.

@seonghobae
seonghobae marked this pull request as draft September 3, 2026 05:42
@seonghobae seonghobae added the status: blocked Blocked by conflict, dependency, or required prerequisite label Sep 3, 2026 — with ChatGPT Codex Connector
@seonghobae seonghobae removed the status: needs-review Open pull request requiring current-head review or checks label Sep 3, 2026
@seonghobae
seonghobae marked this pull request as ready for review September 7, 2026 02:09

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

현재 exact head 3f8b0cdafcba27d595fd13c125457bbf4b8df484의 4-file scratch/debug cleanup delta를 독립적으로 검토해 주세요. Ready 전환은 review admission일 뿐이며, 이전 Devin COMMENTED·cancelled/failed central checks나 predecessor evidence를 이 SHA의 승인으로 승계하지 않습니다. 현재 diff 밖 attachment-parser finding은 이 cleanup PR의 product finding으로 확장하지 말아 주세요.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base="042b0c70531b229af3acbd0421a2f23098d848b3"
head="3f8b0cdafcba27d595fd13c125457bbf4b8df484"

echo "== Checked-out HEAD =="
git rev-parse HEAD
echo "== Commit metadata =="
git show -s --format='%H%n%P%n%s' "$head"

echo "== Exact name-status diff =="
git diff --name-status "$base" "$head"

echo "== Exact stat =="
git diff --stat "$base" "$head"

echo "== Deleted file contents at base =="
for path in plan.md test_parse.py test_parse2.py test_parse3.py; do
  echo "---- $path ----"
  git show "$base:$path" | nl -ba
done

echo "== Repository references to removed paths, excluding Git metadata =="
rg -n -i -C 2 \
  '(?:^|[/"` ])(?:plan\.md|test_parse(?:2|3)?\.py)(?:$|[/"` :])' \
  -g '!**/.git/**' . || true

echo "== Relevant repository automation/config files =="
fd -HI -t f \
  '^(Makefile|README(\.md)?|pyproject\.toml|pytest\.ini|tox\.ini|setup\.cfg|package\.json|\.github)$' \
  . 2>/dev/null | sort || true

Length of output: 1944


🏁 Script executed:

#!/bin/bash
set -euo pipefail

base="042b0c70531b229af3acbd0421a2f23098d848b3"
head="3f8b0cdafcba27d595fd13c125457bbf4b8df484"

echo "== Deleted file contents at base =="
for path in plan.md test_parse.py test_parse2.py test_parse3.py; do
  echo "---- $path ----"
  git show "$base:$path" | awk '{ printf "%6d\t%s\n", NR, $0 }'
done

echo "== Tracked references at base =="
git grep -n -i -E '(^|[^[:alnum:]_.-])(plan\.md|test_parse\.py|test_parse2\.py|test_parse3\.py)($|[^[:alnum:]_.-])' "$base" -- \
  ':!plan.md' ':!test_parse.py' ':!test_parse2.py' ':!test_parse3.py' || true

echo "== Tracked references at exact head =="
git grep -n -i -E '(^|[^[:alnum:]_.-])(plan\.md|test_parse\.py|test_parse2\.py|test_parse3\.py)($|[^[:alnum:]_.-])' "$head" || true

echo "== Root-level tracked files at base =="
git ls-tree --name-only "$base" | sed -n '1,160p'

echo "== Root-level tracked files at exact head =="
git ls-tree --name-only "$head" | sed -n '1,160p'

Length of output: 9529


@seonghobae 검토를 완료했습니다.

3f8b0cdafcba27d595fd13c125457bbf4b8df484develop@042b0c70531b229af3acbd0421a2f23098d848b3와 비교했습니다. diff는 plan.md, test_parse.py, test_parse2.py, test_parse3.py의 삭제만 포함합니다. 총 92줄이 삭제되었고, 추가 또는 수정은 없습니다.

삭제된 Python 파일은 sys.path를 변경하고 내부 services.text_safety 도우미를 호출하는 독립 디버그 스크립트입니다. 삭제된 plan.md는 임시 구현 계획입니다. 현재 남아 있는 plan.md 문자열은 첨부 파일 이름 fixture 또는 문서 예시이며, 삭제된 루트 파일을 참조하지 않습니다.

이 cleanup delta에서 제품 동작, 테스트 실행, 또는 자동화 구성에 영향을 주는 문제를 찾지 못했습니다. 요청에 따라 diff 밖 attachment-parser 항목은 검토 범위에 포함하지 않았습니다.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance priority: medium Normal-priority or P2 work status: blocked Blocked by conflict, dependency, or required prerequisite type: maintenance Maintenance, build, dependency, or operational upkeep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant