fix: remove invalid root npm Dependabot job - #1088
Conversation
|
PR governance metadata gate is not ready for
|
There was a problem hiding this comment.
Noema PydanticAI review
The PR removes an invalid root-level npm update job from the Dependabot config. It also adds or enforces the 'cooldown' field for update jobs and adds test coverage in 'backend/tests/test_release_governance.py' to ensure npm directories tracked by Dependabot actually have a package manifest and that all update jobs enforce a minimum cooldown. All workflow checks, static analysis (SARIF), dependency, and governance checks are passing. No MEDIUM-or-higher dependency findings are open. Tests confirm configuration correctness. The evidence supports approval: the PR improves configuration maintainability and correctness, with no indication of regression or risk.
Findings
-
No blocking findings.
-
Result: APPROVE
-
Verdict: approve
-
Confidence: high
-
Head SHA:
ddf94fba9cd22d1d3d70d004f64718884abc9cf1 -
Reviewer credential:
noema-github-app
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headddf94fba9cd22d1d3d70d004f64718884abc9cf1. -
Head SHA:
ddf94fba9cd22d1d3d70d004f64718884abc9cf1 -
Workflow run: 29881496708
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: dependabot.yml"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: dependabot.yml"]
R1 --> V1["required checks"]
Evidence --> S2["Backend: test_release_governance.py"]
S2 --> I2["API and service runtime"]
I2 --> R2["Review risk: Backend: test_release_governance.py"]
R2 --> V2["backend tests"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: dependabot.yml"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: dependabot.yml"]
R1 --> V1["required checks"]
Evidence --> S2["Backend: test_release_governance.py"]
S2 --> I2["API and service runtime"]
I2 --> R2["Review risk: Backend: test_release_governance.py"]
R2 --> V2["backend tests"]
|
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
Closing after Loop drain: permanently blocked — branch was updated onto develop for mergeability, which cleared prior APPROVED robot evidence; re-review (CodeRabbit/OpenCode) and/or central gate jobs (metadata-only gate evaluation, coverage-evidence) remained pending/stuck without a re-runnable workflow handle. Not force-merging (merge-gate policy). Re-open a focused PR when robot capacity is available. Related product security fixes that reimplemented cleanly remain on branch goal/carddav-path-traversal-decode (#1206) for relaunch. |
Description
The default-branch Dependabot update job fails with
dependency_file_not_found: /package.json not foundbecause.github/dependabot.ymldeclares an npm workspace at/, while this repository keeps its npm manifest under/frontend.This PR removes the invalid root npm update entry, keeps the existing
/frontendnpm group active, and adds a release-governance regression test requiring every configured npm directory to containpackage.json.It also enforces a seven-day Dependabot cooldown for all eight configured ecosystems so newly published versions receive an observation window before automated update PRs are opened.
Current default-branch failure evidence: https://github.com/ContextualWisdomLab/naruon/actions/runs/29713481048 (
developHEAD58d19ee90b34c9cf18c163c03f1f8f05bbce2dce)Type of change
Validation
uv run --project backend --locked python -m pytest backend/tests/test_release_governance.py -q— 35 passedpython -m ruff check backend/tests/test_release_governance.pygit diff --check.github/dependabot.ymlwith PyYAML and confirmed eight update entries, valid npm manifests, and seven-day cooldownscodegraph syncand targeted post-change explorationChecklist