Skip to content

fix(build): bind Maven Wrapper distribution to reviewed SHA-256 - #319

Merged
github-actions[bot] merged 2 commits into
developfrom
repair/maven-wrapper-integrity-8f96517
Aug 13, 2026
Merged

fix(build): bind Maven Wrapper distribution to reviewed SHA-256#319
github-actions[bot] merged 2 commits into
developfrom
repair/maven-wrapper-integrity-8f96517

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Implements issue #265 from exact protected base develop@8f96517987cf2cab4398696503b22a131a4b66a6 without rewriting TDD history.

TDD lineage:

  • 2206afe476189856759bd3cedd989debf697eb9f — test-only RED requiring the fixed Maven 3.9.11 distribution URL to carry its reviewed SHA-256.
  • 717945e15ca944d6592d77f2ab504cb9da9e8e3a — smallest GREEN: adds distributionSha256Sum=0d7125e8c91097b36edb990ea5934e6c68b4440eef4ea96510a0f6815e7eeadb while preserving Wrapper 3.3.4, only-script, Maven 3.9.11, and the distribution URL.

Current-head hosted aggregates are terminal-success: CI 31690169809, Dependency Review 31690169850, CycloneDX SBOM 31690169804, SAST Semgrep 31690169845, and Security Scan 31690169851. These are current PR evidence only; synthetic-merge execution, scanner-completeness, repository-wide coverage, and independent-review requirements remain separate gates and no predecessor-head evidence transfers.

CodeRabbit skipped while Draft. Marking ready should trigger the ordinary review path; merge still requires unchanged exact head, zero valid unresolved findings, qualifying independent non-author formal approval, and all live governance gates.

Summary by CodeRabbit

  • 개선 사항
    • Maven Wrapper 배포 파일의 SHA-256 검증값을 추가해 배포 파일 무결성 확인을 강화했습니다.
    • Maven Wrapper 설정과 고정된 배포 URL, 체크섬 형식을 자동으로 검증하는 테스트를 추가했습니다.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aa316f4d-bfbe-4c5b-a7f1-a35596d75ac4

📥 Commits

Reviewing files that changed from the base of the PR and between 8f96517 and 717945e.

📒 Files selected for processing (2)
  • .mvn/wrapper/maven-wrapper.properties
  • etl-service/src/test/java/com/xtrmetl/etl/documentation/MavenWrapperIntegrityTest.java

📝 Walkthrough

Walkthrough

Maven Wrapper 설정에 Maven 배포 ZIP의 SHA-256 체크섬을 추가했습니다. JUnit 테스트는 Wrapper 버전, 배포 유형, 고정 URL, 체크섬 형식과 값을 검증합니다.

Changes

Maven Wrapper 무결성

Layer / File(s) Summary
Wrapper 체크섬 설정 및 검증
.mvn/wrapper/maven-wrapper.properties, etl-service/src/test/java/com/xtrmetl/etl/documentation/MavenWrapperIntegrityTest.java
Maven Wrapper 설정에 distributionSha256Sum을 추가했습니다. 테스트는 저장소 루트를 탐색하고 설정 파일의 존재 여부, Wrapper 버전, 배포 유형, Maven 3.9.11 URL, SHA-256 형식과 검토된 값을 검증합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 71794

This localized change binds the Maven Wrapper distribution to the reviewed SHA-256 without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 Maven Wrapper 배포 파일에 검토된 SHA-256 체크섬을 추가하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch repair/maven-wrapper-integrity-8f96517

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title test(build): reproduce Maven wrapper integrity gap on live develop fix(build): bind Maven Wrapper distribution to reviewed SHA-256 Aug 13, 2026
@seonghobae
seonghobae marked this pull request as ready for review August 13, 2026 13:04
@github-actions
github-actions Bot merged commit b50ba31 into develop Aug 13, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant