Skip to content

test(cdc): rebuild PostgreSQL SPI config truth on live develop - #294

Closed
seonghobae wants to merge 2 commits into
developfrom
repair/postgres-spi-config-truth-ae4efe6
Closed

test(cdc): rebuild PostgreSQL SPI config truth on live develop#294
seonghobae wants to merge 2 commits into
developfrom
repair/postgres-spi-config-truth-ae4efe6

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Rebuilds issue #238 from exact protected develop@ae4efe6b2c65fb6353bb81ace618bb03c42d3081 without rewriting stale Draft #239.

This replacement is intentionally test-only RED at exact source cacc65326fba9b260ff945a056f8e6318f215fdc. The focused test reaches PostgresDebeziumCdcSource.start(config) with a non-empty credential-like per-call map and requires a stable non-sensitive rejection before CdcService interaction. Protected source still accepts that map and silently ignores it, so a valid hosted RED must be exactly the missing IllegalArgumentException after normal CDC compilation/test startup.

After valid RED, apply the smallest production correction: preserve null rejection and empty-map delegation, reject every non-empty per-call map before service lookup, and document the deployment-owned configuration authority in beginner-readable public Javadocs. Then address the still-valid CodeRabbit coverage finding inherited from #239 by proving start(null) rejects without service interaction and start(Map.of()) delegates to service.start(); old reviews/checks do not transfer.

Keep Draft. This slice changes no credential, Debezium environment authority, connector registry, POM/coverage control, or canonical documentation branch. Merge remains separately gated by exact-source deterministic/security evidence, complete same-revision dependency/vulnerability materialization, non-vacuous applicable owned-production statement/branch coverage, zero valid unresolved findings, and qualifying independent non-author formal approval.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22441f76-7531-4414-8522-61a31f5f3a32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant