test(cdc): rebuild PostgreSQL SPI config truth on live develop - #294
Closed
seonghobae wants to merge 2 commits into
Closed
test(cdc): rebuild PostgreSQL SPI config truth on live develop#294seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds issue #238 from exact protected
develop@ae4efe6b2c65fb6353bb81ace618bb03c42d3081without rewriting stale Draft #239.This replacement is intentionally test-only RED at exact source
cacc65326fba9b260ff945a056f8e6318f215fdc. The focused test reachesPostgresDebeziumCdcSource.start(config)with a non-empty credential-like per-call map and requires a stable non-sensitive rejection beforeCdcServiceinteraction. Protected source still accepts that map and silently ignores it, so a valid hosted RED must be exactly the missingIllegalArgumentExceptionafter normal CDC compilation/test startup.After valid RED, apply the smallest production correction: preserve
nullrejection and empty-map delegation, reject every non-empty per-call map before service lookup, and document the deployment-owned configuration authority in beginner-readable public Javadocs. Then address the still-valid CodeRabbit coverage finding inherited from #239 by provingstart(null)rejects without service interaction andstart(Map.of())delegates toservice.start(); old reviews/checks do not transfer.Keep Draft. This slice changes no credential, Debezium environment authority, connector registry, POM/coverage control, or canonical documentation branch. Merge remains separately gated by exact-source deterministic/security evidence, complete same-revision dependency/vulnerability materialization, non-vacuous applicable owned-production statement/branch coverage, zero valid unresolved findings, and qualifying independent non-author formal approval.