test(security): reject Basic at the ETL service boundary - #280
Closed
seonghobae wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fail-first security work for #161 from exact protected
develop@942d164ceb7af497bb28a95f842db96429d1bdc4.This Draft adds only
EtlServiceAuthenticationModeTest. The test registers the real productionSecurityConfig, installs a valid in-memory test principal, builds MockMvc with the actual Spring Security filter chain, and exercises a protected/api/**route. Unauthenticated access must remain rejected, and credentials valid only for the historical HTTP Basic mechanism must also be rejected by the acquisition-ready target boundary.Protected
SecurityConfigcurrently enableshttpBasic(...), so the intended hosted result is RED because those Basic credentials authenticate and reach the protected test endpoint. A setup/context/controller/import/dependency failure does not count as RED.Writer / implementation boundary
No production authentication mutation is included. The eventual GREEN still requires the independently authenticated ETL mechanism specified by #161, including the required dependency/POM work. Active PR #164 owns the ETL POM coverage boundary, so this branch does not race that writer or invent an issuer, JWK set, audience, credential, certificate authority, or compatibility secret.
Exact identity
942d164ceb7af497bb28a95f842db96429d1bdc4;53920b125513ab3161bcd86f2afed3fc41d249a9;942d164ceb7af497bb28a95f842db96429d1bdc4;Acceptance boundary
Keep Draft until hosted execution proves the intended single security assertion failure on the current Basic filter chain. Synthetic merge evidence is development evidence only; it is not literal-source merge authority. Production GREEN requires the final runtime mechanism, machine-readable contract, SAST, complete security/dependency evidence, non-vacuous owned-production coverage, and qualifying independent review on an unchanged exact head.