Skip to content

fix(security): redact replication-slot diagnostics - #262

Closed
seonghobae wants to merge 1 commit into
developfrom
fix/replication-slot-diagnostic-confidentiality-942d164
Closed

fix(security): redact replication-slot diagnostics#262
seonghobae wants to merge 1 commit into
developfrom
fix/replication-slot-diagnostic-confidentiality-942d164

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Fixes #261.

Strict test-first status-boundary confidentiality repair from exact protected develop@942d164ceb7af497bb28a95f842db96429d1bdc4.

RED candidate

Exact test-only head c6d7830b92f0bdaa7a526dba7236f49f35e86f77 changes only ReplicationSlotProbeTest. It injects a DataAccessResourceFailureException containing an unmistakable JDBC URL/user/password diagnostic and requires the structured fail-open status to retain available=false and error=query_failed while exposing only Replication slot query failed.

Protected production currently returns the most-specific exception message (merely truncated) and also includes e.toString() in a debug log, so this test is expected to fail at the operator-status production boundary. The synthetic credential-shaped value is test-only and must not be logged.

Keep Draft through fail-first proof. After hosted RED reaches the intended boundary, make the smallest response/log redaction, preserve structured status semantics, rerun focused/full validation, and keep inherited/shared scanner, non-vacuous coverage, literal-source and independent-review governance gaps separate.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e2fdbe0-6fa8-48c5-8dfc-1047c4eae623

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as a proven duplicate of #170, not as completed work. #170 already carries hosted RED→GREEN coverage for the same replication-slot confidentiality boundary: it preserves available=false/error=query_failed, replaces driver diagnostics with a stable non-sensitive message, and also removes exception-derived debug logging. This newer test-only branch adds no unique production behavior that is not already covered there. Issue #261 remains open until an accepted fix reaches protected develop.

@seonghobae seonghobae closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Keep replication-slot status diagnostics confidential

1 participant