fix(security): redact replication-slot diagnostics - #262
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as a proven duplicate of #170, not as completed work. #170 already carries hosted RED→GREEN coverage for the same replication-slot confidentiality boundary: it preserves |
Fixes #261.
Strict test-first status-boundary confidentiality repair from exact protected
develop@942d164ceb7af497bb28a95f842db96429d1bdc4.RED candidate
Exact test-only head
c6d7830b92f0bdaa7a526dba7236f49f35e86f77changes onlyReplicationSlotProbeTest. It injects aDataAccessResourceFailureExceptioncontaining an unmistakable JDBC URL/user/password diagnostic and requires the structured fail-open status to retainavailable=falseanderror=query_failedwhile exposing onlyReplication slot query failed.Protected production currently returns the most-specific exception message (merely truncated) and also includes
e.toString()in a debug log, so this test is expected to fail at the operator-status production boundary. The synthetic credential-shaped value is test-only and must not be logged.Keep Draft through fail-first proof. After hosted RED reaches the intended boundary, make the smallest response/log redaction, preserve structured status semantics, rerun focused/full validation, and keep inherited/shared scanner, non-vacuous coverage, literal-source and independent-review governance gaps separate.