Skip to content

fix(security): redact CDC stop diagnostics #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

fix(security): redact CDC stop diagnostics #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cdc-service/src/test/java/com/xtrmetl/cdc/controller/CdcControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,15 @@ void testStopCdc() throws IOException {
}

@Test
void testStopCdcWithException() throws IOException {
doThrow(new IOException("Error stopping CDC")).when(cdcService).stop();
void testStopCdcWithExceptionDoesNotExposeDiagnostic() throws IOException {
String sensitiveDiagnostic = "broker-password=secret-value at /srv/private/cdc.offsets";
doThrow(new IOException(sensitiveDiagnostic)).when(cdcService).stop();

ResponseEntity<String> response = cdcController.stopCdc();

assertEquals(HttpStatus.INTERNAL_SERVER_ERROR, response.getStatusCode());
assertEquals("Error stopping CDC process: Error stopping CDC", response.getBody());
assertEquals("Error stopping CDC process", response.getBody());
assertFalse(response.getBody().contains(sensitiveDiagnostic));
verify(cdcService, times(1)).stop();
}

Expand Down
Loading