feat(etl): rebuild cancellation on refreshed conditional-status stack - #254
Draft
seonghobae wants to merge 20 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack repair
This Draft repairs the first currently invalid durable-job boundary. Fresh ancestry proved current predecessor PR #146 advanced to
894e1fdcb3ad212f35ae0b8c7665b6e495e2eb87, while old cancellation PR #147 remains rooted at historical predecessor9e4d69e0bb33ab57627c697a5d028b5309eca2bband is now diverged (ahead 31 / behind 6, merge base9e4d69e...). The six predecessor commits are confined to the CDC engine health-indicator/test path, while #147's cancellation delta is ETL/docs-only, so this replacement starts from the exact current #146 head rather than rewriting history.TDD phase
Exact current replacement head
f50be481b2b19e6fb566e5430f2d6aac6437fdd4contains only the first cancellation result contract test. ProductionEtlJobCancellationand theCANCELLEDstatus contract are intentionally absent on this ancestry, so the expected first hosted result is RED at the missing cancellation production boundary. Setup/import/dependency/runner failure will not count as valid RED.After valid RED, rebuild the proven cancellation slice through narrow auditable GREEN commits, then restore concurrency/migration/controller/service/documentation tests and prove unique-work equivalence to #147 before considering #147 superseded. No checks/reviews/approvals from #147 transfer. Do not repair downstream replay #148 until this boundary is stack-valid and verified.
No force-push, destructive rebase, ours/theirs shortcut, gate weakening, protection bypass, or cross-repository write is permitted.