Skip to content

fix(connectors): remove Qlik scaffold from production registry - #156

Draft
seonghobae wants to merge 14 commits into
developfrom
fix/remove-qlik-scaffold-registry
Draft

fix(connectors): remove Qlik scaffold from production registry#156
seonghobae wants to merge 14 commits into
developfrom
fix/remove-qlik-scaffold-registry

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Advance #153 with one bounded connector decision: stop publishing Qlik Sense as a TargetConnector.write(...) row sink or production connector configuration surface until mightyETL implements Qlik's actual supported reload/data-file/application orchestration boundary. The active branch removes a permanently refusing scaffold from production registry/catalog/configuration binding while retaining only clearly non-registered reference/design material.

Nothing here is implemented_on_develop before protected integration.

Exact current identity

  • protected/live base: develop@622e5e6c3d534f230c390f10e3832efadfc01825;
  • branch: fix/remove-qlik-scaffold-registry;
  • exact current source head: f04512c4cce2f0c1d33e74286cda2628050784b9;
  • current synthetic merge preview: e9776fc658ddea095d9a199a6b0f103f6a8e9238;
  • Draft / mergeable: true / true;
  • formal reviews: none at the latest fresh snapshot.

Every predecessor-head/base check, review or approval is historical and does not transfer.

RCA / product decision

Protected source registered Qlik in TargetConnectorRegistry, advertised it in the connector catalog, exposed a Spring QlikSenseProps configuration subtree and mirrored its enable key, while the production write(...) path permanently refused operation. Hiding only one catalog row would leave a misleading product surface.

The bounded terminal outcome is therefore:

  • no Qlik production registry/catalog publication;
  • no Qlik production Spring configuration binding or modern/legacy enable alias;
  • generic Qlik enable/config lookup remains fail-closed/empty;
  • the historical class may remain only as non-registered reference/design material;
  • Databricks/Snowflake remain separately tracked by [Product gap] Eliminate production scaffold-only connector implementations #153.

A future Qlik integration requires a separately reviewed provider-native reload/data-file/application contract and realistic integration evidence; no fake warehouse row-write API is invented here.

TDD record

The branch preserves test-first history for both production registry/catalog retirement and the later-discovered configuration-binding/alias surface. Current Qlik-specific tests require explicit absence from production discovery/config binding while keeping reference material distinguishable from supported connectors.

Fresh hosted evidence

All exposed pull-request workflow aggregates for exact source head f04512c4cce2f0c1d33e74286cda2628050784b9 are terminal-success:

  • CycloneDX SBOM 31319383346: success;
  • SAST Semgrep 31319383352: success;
  • Dependency Review 31319383410: success;
  • CI 31319383359: success;
  • Security Scan 31319383355: success.

These aggregates do not authorize merge. Protected PR workflows execute GitHub's generated integration revision rather than accepted literal source, protected JaCoCo remains a vacuous evidence path until #162/#164 integrates, and #196 requires dependency/vulnerability evidence to be treated as incomplete when Trivy cannot resolve BOM-managed Maven versions even if the aggregate is green. Source identity, scanner completeness and non-vacuous coverage are independent requirements.

Relationship to newly discovered registry integrity work

Issue #203 identifies a separate protected TargetConnectorRegistry invariant: duplicate or blank connector IDs can silently replace registry authority. Do not fold #203 into this PR while this branch owns the registry/catalog retirement surface. After #156 stabilizes/integrates, #203 must re-read the resulting registry and add its own fail-first uniqueness/identity boundary without resurrecting Qlik.

Remaining gates

Keep Draft. Merge only when the unchanged exact source head has accepted literal-source deterministic/security evidence, complete same-revision dependency/vulnerability evidence, non-vacuous owned-production coverage, zero valid unresolved findings, all required repository/security gates and qualifying independent non-author formal approval where governance requires it. No predecessor-head, other-PR, incomplete-scanner, status-only, skipped-required or synthetic-merge-only evidence transfers.

Issue #153 remains open until no production registry/discovery/configuration path advertises a connector whose only runtime behavior is scaffold validation/refusal.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f7d7d9f4-5ebe-40b7-b99c-c75f1dd00df6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Rate Limit Exceeded

@seonghobae have exceeded the limit for the number of chat messages per hour. Please wait 16 minutes and 50 seconds before sending another message.

@seonghobae seonghobae added the bug Something isn't working label Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: medium Normal-priority or P2 work status: draft Draft pull request type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant