fix(connectors): remove Qlik scaffold from production registry - #156
fix(connectors): remove Qlik scaffold from production registry#156seonghobae wants to merge 14 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
Rate Limit Exceeded
|
Purpose
Advance #153 with one bounded connector decision: stop publishing Qlik Sense as a
TargetConnector.write(...)row sink or production connector configuration surface until mightyETL implements Qlik's actual supported reload/data-file/application orchestration boundary. The active branch removes a permanently refusing scaffold from production registry/catalog/configuration binding while retaining only clearly non-registered reference/design material.Nothing here is
implemented_on_developbefore protected integration.Exact current identity
develop@622e5e6c3d534f230c390f10e3832efadfc01825;fix/remove-qlik-scaffold-registry;f04512c4cce2f0c1d33e74286cda2628050784b9;e9776fc658ddea095d9a199a6b0f103f6a8e9238;Every predecessor-head/base check, review or approval is historical and does not transfer.
RCA / product decision
Protected source registered Qlik in
TargetConnectorRegistry, advertised it in the connector catalog, exposed a SpringQlikSensePropsconfiguration subtree and mirrored its enable key, while the productionwrite(...)path permanently refused operation. Hiding only one catalog row would leave a misleading product surface.The bounded terminal outcome is therefore:
A future Qlik integration requires a separately reviewed provider-native reload/data-file/application contract and realistic integration evidence; no fake warehouse row-write API is invented here.
TDD record
The branch preserves test-first history for both production registry/catalog retirement and the later-discovered configuration-binding/alias surface. Current Qlik-specific tests require explicit absence from production discovery/config binding while keeping reference material distinguishable from supported connectors.
Fresh hosted evidence
All exposed pull-request workflow aggregates for exact source head
f04512c4cce2f0c1d33e74286cda2628050784b9are terminal-success:31319383346: success;31319383352: success;31319383410: success;31319383359: success;31319383355: success.These aggregates do not authorize merge. Protected PR workflows execute GitHub's generated integration revision rather than accepted literal source, protected JaCoCo remains a vacuous evidence path until #162/#164 integrates, and #196 requires dependency/vulnerability evidence to be treated as incomplete when Trivy cannot resolve BOM-managed Maven versions even if the aggregate is green. Source identity, scanner completeness and non-vacuous coverage are independent requirements.
Relationship to newly discovered registry integrity work
Issue #203 identifies a separate protected
TargetConnectorRegistryinvariant: duplicate or blank connector IDs can silently replace registry authority. Do not fold #203 into this PR while this branch owns the registry/catalog retirement surface. After #156 stabilizes/integrates, #203 must re-read the resulting registry and add its own fail-first uniqueness/identity boundary without resurrecting Qlik.Remaining gates
Keep Draft. Merge only when the unchanged exact source head has accepted literal-source deterministic/security evidence, complete same-revision dependency/vulnerability evidence, non-vacuous owned-production coverage, zero valid unresolved findings, all required repository/security gates and qualifying independent non-author formal approval where governance requires it. No predecessor-head, other-PR, incomplete-scanner, status-only, skipped-required or synthetic-merge-only evidence transfers.
Issue #153 remains open until no production registry/discovery/configuration path advertises a connector whose only runtime behavior is scaffold validation/refusal.