feat(release): verify detached release signatures - #236
Draft
seonghobae wants to merge 14 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Canonical successor to #222, stacked on current #217. This advances #210 from structural signature-presence evidence to a cryptographic operator-verification boundary. It does not publish a release candidate, distribute trust roots, or claim release readiness.
The preserved RED/GREEN lineage verifies detached Ed25519 signatures, rejects forged/substituted/non-canonical evidence and unknown trust identity, exposes bounded
verify-release, and uses same-descriptorO_NOFOLLOWJSON/artifact trust boundaries. The signedlife-os.release-signature.v1statement binds source commit, channel, version, artifact name and SHA-256 digest. Trust is never inferred from embedded keys, GitHub actors or model output.Key issuance/rotation/revocation/custody, Sigstore/cosign identity policy, transparency-log acceptance, publication, install/upgrade/backup/restore and buyer-journey acceptance remain outside this slice.
Current stack
Parent #217 now adopts protected
main@b84751674dd92bdcd0e266c7f002cdc43f5a938bas exact heade2965452ddb9227c5a0462a7820f95c70fe11821, preserving #240's repaired CI/Commercial Readiness trigger semantics.Current child head
4a24880dc90628f25de115c961ac9131b1b7f0a4is a non-force two-parent descendant of prior child47a9edaebace6304d2e848505fe9e00823dac0d2and current parent #217. Fresh compare frome2965452...is ahead-only (behind_by=0) and contains exactly the six signature-verification-owned paths; parent release-evidence files and protected-main workflow blobs are inherited unchanged.No predecessor review/check evidence transfers after this head move. Keep Draft while #217 is unmerged; after normal parent integration, retarget/restack non-destructively and reacquire exact-head repository/central workflow and current review evidence. Queued, absent, predecessor or skipped evidence is not passing.
Refs #210, #217, #222.