fix(calendar): reject deployment-wide provider credentials in hosted runtime - #216
Draft
seonghobae wants to merge 11 commits into
Draft
fix(calendar): reject deployment-wide provider credentials in hosted runtime#216seonghobae wants to merge 11 commits into
seonghobae wants to merge 11 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@coderabbitai review |
|
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security/product boundary
The hosted multi-user Calendar runtime must not use deployment-wide provider credentials as request authority. Protected main already has user-owned connection metadata, encrypted Calendar secret storage and credential materialization primitives, but the production bootstrap still composed process-wide Google or CalDAV credentials while synchronization authority was only workspace-scoped.
Test-first change
768383f9e68a7534420ab464fc586e6e798486deand GREENc6e017fe3c8df823270a448d04aef8906c3838cdremoved the deployment-wide Google path from hosted composition while retaining explicitly invoked standalone Google composition.224b2f66f7f99210cd04f6452bc7f1bee96d15abrequires hosted composition to reject both Google and CalDAV process-wide credentials.256e33f9c72ebe483943143ad6202ed7ca7f4284makes the hosted factory fail closed for both supported standalone providers until authenticated user-owned connection evidence and scoped secret materialization are composed.This advances #129 but does not complete it. Hosted user-scoped provider composition, OAuth callback/token exchange/refresh, provider cleanup, calendar discovery/selection and end-to-end scoped synchronization remain required. Stacked #228 now owns the bounded Google OAuth authorization-state/PKCE slice and is non-force restacked on this exact parent.
Protected-main adoption
Protected main advanced through merged runner-control foundation #218 to
193a87ef54c3fe6dcda4755bce4d6bc81e3a0297.Current exact head
217370c8effcd96b760e7b32f4cf4f117385133dis a non-force two-parent descendant of prior Calendar heade322b2bc0981d8acc708b5b3ae680459e33b2e8aand current protected main. Fresh compare from protected main is ahead-only (behind_by=0,ahead_by=11) with exactly six Calendar/configuration/documentation paths:.env.example,ARCHITECTURE.md,CHANGELOG.md,README.md, the provider-environment test, and Calendarmain.ts. Shared workflow/control-plane changes arrive through ancestry only.Fresh exact-head CI, Security Scan, SAST Semgrep, CodeQL PR, Commercial Readiness and AppGuardrail runs are all queued. Queued evidence is not GREEN. No predecessor check/review evidence transfers after the head move.
Keep Draft until the unchanged exact head has terminal applicable repository/security checks, current independent review/thread requirements and live-base compatibility. No self-approval, bypass, force-push, destructive rebase, stale evidence reuse or gate weakening.
Refs #129, #228.