fix(planning): serialize data-rights export queries - #215
Conversation
|
Warning Review limit reachedNext included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes내보내기 쿼리 직렬화
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The Planning data-rights export now executes its existing reads sequentially within the same transaction, avoiding unsupported overlapping queries while preserving export behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #219 after exact diff comparison against current |
Why
The current Planning data-rights export opens one repeatable-read transaction and then launches five
client.query()streams concurrently throughPromise.all. The PostgreSQL driver already emits a deprecation warning whenclient.query()is called while that same client is executing another query, and pg 9 is expected to reject that usage.Change
RCA / acceptance
First failing boundary: transaction-owned PostgreSQL client query scheduling, not SQL formatting, coverage, permissions, or database readiness.
Falsifiable acceptance: the new regression must pass without overlapping queries, and the repository CI must complete without the prior
Calling client.query() when the client is already executing a query is deprecatedwarning from Planning data-rights export.This PR does not change the shared data-rights contract or claim completion of #55.
Summary by CodeRabbit