Skip to content

ci(actions): skip draft pull request jobs - #147

Merged
seonghobae merged 1 commit into
mainfrom
codex/actions-draft-admission
Sep 4, 2026
Merged

ci(actions): skip draft pull request jobs#147
seonghobae merged 1 commit into
mainfrom
codex/actions-draft-admission

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

요약

  • PR lifecycle 이벤트를 명시해 Ready 전환 시 current-head 검증을 시작합니다.
  • Draft와 closed PR에서는 세 CI job을 runner에 배정하지 않습니다.
  • 기존 workflow-repository-PR concurrency와 non-PR 격리를 유지합니다.

검증

  • actionlint .github/workflows/ci.yml
  • uv run --locked --project services/account_unification --extra dev pytest -q services/account_unification/tests/test_workflow_concurrency_contract.py3 passed, 경고 없음

전체 actionlint의 기존 hourly-product-development SC2016은 #146이 해당 직접 NIM loop를 삭제하며 소유합니다. 이 PR은 Actions 60-job ceiling 수리만 포함합니다.

Summary by CodeRabbit

  • CI 개선

    • 초안 상태이거나 종료된 풀 리퀘스트에서는 검증 작업이 실행되지 않도록 변경했습니다.
    • 생성, 업데이트, 재오픈, 리뷰 준비 완료 등 주요 풀 리퀘스트 이벤트와 코드 푸시 시 검증이 실행됩니다.
  • 테스트

    • 위 CI 실행 조건이 의도대로 적용되는지 자동으로 확인하는 검증을 추가했습니다.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T22:26:42.712061Z 4c056aa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seonghobae
seonghobae merged commit 7d9151c into main Sep 4, 2026
10 of 18 checks passed
@seonghobae
seonghobae deleted the codex/actions-draft-admission branch September 4, 2026 22:23
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0677bb96-6c04-45e3-aa5d-b77d17950a44

📥 Commits

Reviewing files that changed from the base of the PR and between 100917d and 4c056aa.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • services/account_unification/tests/test_workflow_concurrency_contract.py

📝 Walkthrough

Walkthrough

CI 워크플로가 지정된 pull request 이벤트에서만 실행됩니다. 초안 또는 종료된 pull request에서는 세 작업을 건너뜁니다. 계약 테스트가 이벤트 목록과 작업 조건을 검증합니다.

Changes

CI pull request 실행 조건

Layer / File(s) Summary
워크플로 이벤트 및 작업 실행 조건
.github/workflows/ci.yml, services/account_unification/tests/test_workflow_concurrency_contract.py
pull request 이벤트 유형을 제한합니다. 초안 또는 종료된 pull request에서는 account-unification-tests, realm-config-validates, compose-config-validates 작업을 건너뜁니다. 계약 테스트가 이벤트 목록과 세 작업의 조건을 검증합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/actions-draft-admission

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c056aaee3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
push:
branches: [main]
pull_request:
types: [opened, synchronize, reopened, ready_for_review, converted_to_draft, closed]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document the new draft-PR CI behavior

This changes externally observable automation behavior by suppressing all three CI jobs for draft and closed pull requests, but the commit leaves CHANGELOG.md, the CI/operator documentation, and the doctoring record unchanged. Document when these checks are skipped and rerun—especially that skipped jobs are not exact-head verification—so maintainers and automation do not misinterpret draft-head evidence; repository policy requires these documentation updates whenever behavior changes.

AGENTS.md reference: AGENTS.md:L56-L57

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant